<div dir="ltr">ASCII between 0 and 127 rather than 128 ?<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/6 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Chris Muller uploaded a new version of Collections to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Collections-cmm.531.mcz" target="_blank">http://source.squeak.org/trunk/Collections-cmm.531.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Collections-cmm.531<br>
Author: cmm<br>
Time: 6 September 2013, 2:26:33.695 pm<br>
UUID: da0031c2-e1d3-4f49-a425-9808728e3f1a<br>
Ancestors: Collections-ul.530<br>
<br>
- Remove redundant isVariableBinding override.<br>
- Characters can now be tested for isAscii.<br>
- Dictionary's and Set's made proxy-friendly.<br>
- Remove redundant isLiteral override.<br>
- Allow #asMutator to work for getter or setter selectors.<br>
<br>
=============== Diff against Collections-ul.530 ===============<br>
<br>
Item was removed:<br>
- ----- Method: Association>>isVariableBinding (in category 'testing') -----<br>
- isVariableBinding<br>
- "Return true if I represent a literal variable binding"<br>
- ^true!<br>
<br>
Item was added:<br>
+ ----- Method: Character>>isAscii (in category 'testing') -----<br>
+ isAscii<br>
+ ^ value between: 0 and: 128!<br>
<br>
Item was changed:<br>
----- Method: Dictionary>>keysSortedSafely (in category 'accessing') -----<br>
keysSortedSafely<br>
"Answer a sorted Array containing the receiver's keys."<br>
+ ^ self keys sort:<br>
+ [ : x : y | x compareSafely: y ]!<br>
-<br>
- ^self keys sort: [ :x :y |<br>
- "Should really be use <obj, string, num> compareSafely..."<br>
- ((x isString and: [ y isString ])<br>
- or: [ x isNumber and: [ y isNumber ] ])<br>
- ifTrue: [ x < y ]<br>
- ifFalse: [ x class == y class<br>
- ifTrue: [ x printString < y printString ]<br>
- ifFalse: [ x class name < y class name ] ] ].<br>
- !<br>
<br>
Item was changed:<br>
----- Method: Dictionary>>scanFor: (in category 'private') -----<br>
scanFor: anObject<br>
"Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements."<br>
<br>
| index start |<br>
index := start := anObject hash \\ array size + 1.<br>
[<br>
| element |<br>
+ ((element := array at: index) == nil or: [ anObject = element key ])<br>
- ((element := array at: index) == nil or: [ element key = anObject ])<br>
ifTrue: [ ^index ].<br>
(index := index \\ array size + 1) = start ] whileFalse.<br>
self errorNoFreeSpace!<br>
<br>
Item was added:<br>
+ ----- Method: Number>>compareSafely: (in category '*collections') -----<br>
+ compareSafely: aNumber<br>
+ "Override method to compare the receiver with aNumber to determine its position in a human-readable list without unnecessarily agitating proxies."<br>
+ ^ self < aNumber!<br>
<br>
Item was added:<br>
+ ----- Method: Object>>compareSafely: (in category '*collections') -----<br>
+ compareSafely: anObject<br>
+ "Compare the receiver to anObject to determine its position in a human-readable list without unnecessarily agitating proxies."<br>
+ ^ self class = anObject class<br>
+ ifTrue: [ self printString < anObject printString ]<br>
+ ifFalse: [ self class name < anObject class name ]!<br>
<br>
Item was changed:<br>
----- Method: Set>>scanFor: (in category 'private') -----<br>
scanFor: anObject<br>
"Scan the key array for the first slot containing either a nil (indicating an empty slot) or an element that matches anObject. Answer the index of that slot or raise an error if no slot is found. This method will be overridden in various subclasses that have different interpretations for matching elements."<br>
<br>
| index start |<br>
index := start := anObject hash \\ array size + 1.<br>
[<br>
| element |<br>
+ ((element := array at: index) == nil or: [ anObject = element enclosedSetElement ])<br>
- ((element := array at: index) == nil or: [ element enclosedSetElement = anObject ])<br>
ifTrue: [ ^index ].<br>
(index := index \\ array size + 1) = start ] whileFalse.<br>
self errorNoFreeSpace!<br>
<br>
Item was added:<br>
+ ----- Method: String>>asAscii (in category 'converting') -----<br>
+ asAscii<br>
+ ^ self select: [ : each | each isAscii ]!<br>
<br>
Item was added:<br>
+ ----- Method: String>>compareSafely: (in category '*collections') -----<br>
+ compareSafely: aString<br>
+ "Compare the receiver to aString in a way that will not agitate proxies."<br>
+ ^ self < aString!<br>
<br>
Item was changed:<br>
+ ----- Method: String>>isLiteral (in category 'testing') -----<br>
- ----- Method: String>>isLiteral (in category 'printing') -----<br>
isLiteral<br>
+ "Answer whether the receiver is a valid Smalltalk literal."<br>
<br>
+ ^ true!<br>
- ^true!<br>
<br>
Item was changed:<br>
----- Method: Symbol>>asMutator (in category 'converting') -----<br>
asMutator<br>
+ "Return a setter message from a getter message. For example, #name asMutator returns #name:"<br>
+ ^ self last = $:<br>
+ ifTrue: [ self ]<br>
+ ifFalse: [ (self copyWith: $:) asSymbol ]!<br>
- "Return a setter message from a getter message. For example,<br>
- #name asMutator returns #name:"<br>
- ^ (self copyWith: $:) asSymbol!<br>
<br>
Item was removed:<br>
- ----- Method: Symbol>>isLiteral (in category 'testing') -----<br>
- isLiteral<br>
- "Answer whether the receiver is a valid Smalltalk literal."<br>
-<br>
- ^ true!<br>
<br>
Item was added:<br>
+ ----- Method: Symbol>>veryDeepCopy (in category 'copying') -----<br>
+ veryDeepCopy<br>
+ "Overridden for performance."<br>
+ ^ self!<br>
<br>
<br>
</blockquote></div><br></div>