<div dir="ltr"><div>Thanks Yoshiki, that's helpful.<br>So, EncodedCharSet is currently used, but that should better be the LanguageEnvironment (or a more specialized house rule).<br></div>And isBreakable should at least look at a pair of chars (if lines cannot end with prev, or line cannot start with next, or the pair is unbreakable, etc...).<br>
Since you have very accurate names for it, it would be nice to see methods spelled with latin transliteration oikomi oidashi etc... :)<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/25 Yoshiki Ohshima <span dir="ltr"><<a href="mailto:Yoshiki.Ohshima@acm.org" target="_blank">Yoshiki.Ohshima@acm.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">At Tue, 24 Sep 2013 23:21:00 +0200,<br>
<div class="im">Nicolas Cellier wrote:<br>
><br>
> 2013/9/21 tim Rowledge <<a href="mailto:tim@rowledge.org">tim@rowledge.org</a>><br>
><br>
> ><br>
> > a) There are {language}environment classes and encoding classes. There is<br>
> > #isBreakableAt:in: implemented in both but seemingly unused in the encoding<br>
> > classes because it is just plain broken there. Should it be removed from<br>
> > the encoders? In the language environment classes it is implemented to<br>
> > return true for space and cr by default, but space, cr & lf in Latin1 and<br>
> > Latin2. Is that as expected?<br>
> ><br>
> ><br>
> >From what I understand:<br>
> - no need to answer true for space, cr, lf since these are already handled<br>
> in the CharacterScanner stopConditions, so default answer should be ^false<br>
> (unless one of these is removed from stopConditions, I thought I saw that,<br>
> but cannot remember...)<br>
> - whether it should be in EncodedCharSet or LanguageEnvironment, I don't<br>
> know...<br>
><br>
> I don't completely like the Multi* version...<br>
> For example, when the last breakable char is not a space, there is no<br>
> adjustment of space width.<br>
> Maybe Justified makes no sense in Japanese?<br>
> I'd very much like to have tests describing the exepectations...<br>
><br>
<br>
</div>Having tests would have been good, yes. For some reference this might<br>
help a bit. The page rightly mentions contradicting "House Rules" so<br>
it is not clear cut.<br>
<br>
<a href="http://en.wikipedia.org/wiki/Line_breaking_rules_in_East_Asian_languages" target="_blank">http://en.wikipedia.org/wiki/Line_breaking_rules_in_East_Asian_languages</a><br>
<br>
I'd support a rewrite of the whole thing, and perhaps would do more<br>
"total rewrite" approach...<br>
<span class="HOEnZb"><font color="#888888"><br>
-- Yoshiki<br>
<br>
</font></span></blockquote></div><br></div>