<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/27 tim Rowledge <span dir="ltr"><<a href="mailto:tim@rowledge.org" target="_blank">tim@rowledge.org</a>></span><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div class="im"><br>
On 26-09-2013, at 5:19 PM, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
<br>
> I don't understand all you did...<br>
> #scanSelector is still in use sent by #scanSelectorAt:.<br>
> This is because #charsetAt: can answer either a LanguageEnvironment or an EncodedCharSet, so why remove it now?<br>
<br>
</div>It's just the non-used method in EncodedCharSet class.<br>
<div class="im"><br></div></blockquote><div>But these are all class methods... charsetAt: answers a class, not an instance...<br></div><div>So JISX0208 won't understand scanSelector if ever you introduce leadingChar = 4...<br>
</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">
><br>
> Why remove #isBreakable:in:in:? it is still in use by the scanJapanese...<br>
> same for breakAtSpace (for Japanese only).<br>
<br>
</div>I didn't remove the method completely - there is an identical version in MultiCharacterScanner for it to inherit.<br>
<div class="im"><br></div></blockquote><div>OK, my bad, I saw that after posting<br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">
<br>
><br>
> Why remove composeFrom: startIndex inRectangle: snip... ?<br>
> I'm suspect that this is a slip due to moving methods between packages<br>
<br>
</div>Certainly a mistake somewhere to do with moving stuff.<br>
<div class="im"><br>
<br></div></blockquote><div>Yes, my own fault, the update was not ready.<br><br> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="im">
tim<br>
--<br>
tim Rowledge; <a href="mailto:tim@rowledge.org">tim@rowledge.org</a>; <a href="http://www.rowledge.org/tim" target="_blank">http://www.rowledge.org/tim</a><br>
</div>Oxymorons: Clearly misunderstood<br>
<br>
<br>
<br>
</blockquote></div><br></div></div>