<div dir="ltr"><div><div><div><div><div><div>OK, I understand the fix in CharacterBlockScanner because it is better explained in DisplayScanner:<br></div><div>sending stopConditions will initialize alignment inst. var., which for some reasons wasn't set in MVC...<br>
</div><div>Not sure that this is the right fix though... And not sure how this works in Morphic too...<br></div><br></div>I however have found more glitches in Morphic:<br></div>1) if alignment is centered, you can set the blinking cursor to the left of the window by double clicking very near the left border.<br>
</div> Normally, the cursor should go the left of leftmost character...<br></div><div> I suspect that this could be an unset alignment defaulting to left flush<br> (seing all these alignment ifNil:[textStyle alignment] is a clue)<br>
</div><div><br></div>2) in case of WideString, you cannot easily select the leftmost character in a centered line by help of the mouse (unless you go left to window border).<br></div><div> I found that this is due to the leftMargin test in line from scanMultiCharactersFrom:...<br>
nextDestX > rightX ifTrue: [destX ~= leftMargin ifTrue: [^stops crossedX]].<br></div><div> It did work OK when this was firstDestX, so it's me who broke it with Multilingual-nice.179<br></div><div> Indeed, only a MultiCompositionScanner would initialize firstDestX := leftMargin, while the other scanner let it nil...<br>
</div><div><br></div><div>3) The blinking cursor vanishes when cursor is moved at the right of a right flushed line.<br> it even vanishes sooner if last char is blank (space/tab) and the cursor is moved with arrow key (different from mouse click!)<br>
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/29 Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Argh! case of blindness!<br></div>I did not find because I looked at the date and found nothing before 2006!<br>
</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/29 Bob Arning <span dir="ltr"><<a href="mailto:arning315@comcast.net" target="_blank">arning315@comcast.net</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<font face="Georgia">Looks like it's already there<br>
<br>
<a href="http://ftp.squeak.org/updates/updates.list" target="_blank">http://ftp.squeak.org/updates/updates.list</a><br>
<br>
Cheers,<br>
Bob<br>
<br>
</font><div><div>
<div>On 9/28/13 5:30 PM, Nicolas Cellier
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Ah OK, I have some of these images, but first thought
about browsing the web...<br>
</div>
It would be nice if <a href="http://update.squeakfoundation.org/external/updates/updates.list" target="_blank">http://update.squeakfoundation.org/external/updates</a>
were copied to <a href="http://ftp.squeak.org/updates" target="_blank">http://ftp.squeak.org/updates</a>
though.<br>
</div>
<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/9/28 Bob Arning <span dir="ltr"><<a href="mailto:arning315@comcast.net" target="_blank">arning315@comcast.net</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <font face="Georgia">Oh,
I saved *lots* of them. In this case I looked at old
images until I found one containing a different version
of that method. I don't know if anyone has saved
everything one one place, but if you download a lot of
old images, you might be able to find the answer
(although some of them had change sets expunged before
being made available). You can get the one in question
from <a href="http://ftp.squeak.org/3.8/" target="_blank">http://ftp.squeak.org/3.8/</a><br>
<br>
Cheers,<br>
Bob<br>
<br>
</font>
<div>
<div>
<div>On 9/28/13 4:30 PM, Nicolas Cellier wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Ah, thanks Bob, it seems you saved some
historical bits !<br>
<br>
</div>
I saw that previous timestamp was BG 5/31/2003,
I found that it might be
4717CharBlockScannerFix-slg.cs in <a href="http://update.squeakfoundation.org/external/updates/updates.list" target="_blank">http://update.squeakfoundation.org/external/updates/updates.list</a>
but I did not find any way to browse these
change sets.<br>
<br>
</div>
Aren't there available somewhere?<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/9/28 Bob Arning <span dir="ltr"><<a href="mailto:arning315@comcast.net" target="_blank">arning315@comcast.net</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> <font face="Georgia">Change Set:
CenteredTextFix-BG<br>
Date: 31 May 2003<br>
Author: Boris Gaertner<br>
<br>
In an MVC project, centered text is not
displayed centered when it is edited. This
is an attempt to fix that glitch. Please
have a look at it and give it some
testing. After all, a careless change in
CharacterScanner can easily ruin the
image.<br>
=======================<br>
<br>
This was when a second #setStopConditions
was added preceding the rightMargin
setting. My guess is nobody thought to
remove the original #setStopConditions
further down. Then in 2006 the new #</font><font face="Georgia"><font face="Georgia">setStopConditions
was moved after the rightMargin setting.<br>
<br>
</font>Cheers,<br>
Bob<br>
<br>
</font>
<div>
<div>
<div>On 9/28/13 3:51 PM, Nicolas Cellier
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>
<div>Sending twice some
complex initialization
message with inter-mixed
state messing smells...<br>
This is for example in
CharacterBlockScanner>>buildCharacterBlockIn:
<br>
</div>
<br>
</div>
I found <a href="http://bugs.squeak.org/view.php?id=3570" target="_blank">http://bugs.squeak.org/view.php?id=3570</a>
which were included in
Graphics-ar.39<br>
(in 3.9 repository see <a href="http://source.squeak.org/39a/Graphics-ar.39.diff%29." target="_blank">http://source.squeak.org/39a/Graphics-ar.39.diff).</a>..<br>
...but the doubled
setStopConditions was there
already, the change just swapped
some lines...<br>
<br>
</div>
This is not in the Multilingual
branch, so it seems newer than
2002...<br>
<br>
</div>
Does anyone remember where to dig to
understand why, which bug it solves,
which feature it supports, and
whether it is really needed?<br>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br>
</div>
</div>
</div>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br>
</div>
</div>
</div>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre></pre>
</blockquote>
<br>
</div></div></div>
<br><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>