<div dir="ltr">endEntry is, though, essentially obsolete. flush is better; it's more flexible because it works with Transcript and streams, and has a more generally understood meaning. So I'd like to see endEntry deprecated.<br>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 1, 2013 at 9:37 AM, Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@elte.hu" target="_blank">leves@elte.hu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I don't think that #endEntry should be private. AFAIK Transcript wasn't always a stream, and #endEntry was part of Transcript's original protocol.<br>
If you check the senders of #endEntry, then you'll find that the receiver is always "Transcript" or "self". Replacing #endEntry with #flush won't hurt in most cases.<span class=""><font color="#888888"><br>
<br>
<br>
Levente</font></span><div class=""><div class="h5"><br>
<br>
On Tue, 1 Oct 2013, Chris Muller wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I had not noticed the existence of TranscriptStream>>#flush. Clearly,<br>
TranscriptStream>>#endEntry is miscategorized then -- it should be<br>
private, should it not?<br>
<br>
My version comment was intended to say: "When Logging output to a<br>
TranscriptStream, #endEntry is sometimes necessary. So let's still<br>
allow switching to another kind of WriteStream."<br>
<br>
Since flush is available, you're right, we don't need it on<br>
WriteStream. I'll remove it when I get a chance.<br>
<br>
<br>
On Tue, Oct 1, 2013 at 10:56 AM, Levente Uzonyi <<a href="mailto:leves@elte.hu" target="_blank">leves@elte.hu</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Tue, 1 Oct 2013, <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Chris Muller uploaded a new version of Collections to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Collections-cmm.538.mcz" target="_blank">http://source.squeak.org/<u></u>trunk/Collections-cmm.538.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Collections-cmm.538<br>
Author: cmm<br>
Time: 30 September 2013, 7:50:52.954 pm<br>
UUID: f041f162-9c02-499f-866e-<u></u>27d2e1a31b6b<br>
Ancestors: Collections-tpr.537<br>
<br>
- Logging output to a #endEntry is sometimes necessary. So let's still<br>
allow switching to another kind of WriteStream.<br>
</blockquote>
<br>
<br>
I don't see the point of this change. #flush is part of the Stream protocol,<br>
so it's definitely not a compatibility method in WriteStream.<br>
It's better to use #flush instead of #endEntry, because all streams<br>
understand #flush, but only Transcript (and now WriteStream) understands<br>
#endEntry.<br>
<br>
<br>
Levente<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
=============== Diff against Collections-tpr.537 ===============<br>
<br>
Item was added:<br>
+ ----- Method: WriteStream>>endEntry (in category 'compatibility') -----<br>
+ endEntry<br>
+ "No-op for compatibility with TranscriptStream."!<br>
<br>
Item was changed:<br>
+ ----- Method: WriteStream>>flush (in category 'compatibility') -----<br>
- ----- Method: WriteStream>>flush (in category 'file open/close') -----<br>
flush!<br>
<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>