<div dir="ltr"><div>Ah, so you don't pass the stopConditions and kern, good :)<br></div>I think it is a good thing, because those were ALWAYS equal to the scanner inst vars.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
2013/10/8 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
tim Rowledge uploaded a new version of Collections to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Collections-tpr.539.mcz" target="_blank">http://source.squeak.org/trunk/Collections-tpr.539.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Collections-tpr.539<br>
Author: tpr<br>
Time: 8 October 2013, 2:48:12.552 pm<br>
UUID: e33fd51f-59a0-41ab-bbee-08a8a969f31a<br>
Ancestors: Collections-cmm.538<br>
<br>
Strings need to understand how to delegate character scanning to the next stage of the process<br>
<br>
=============== Diff against Collections-cmm.538 ===============<br>
<br>
Item was added:<br>
+ ----- Method: ByteString>>scanCharactersFrom:to:with:rightX:font: (in category 'character scanning') -----<br>
+ scanCharactersFrom: startIndex to: stopIndex with: aCharacterScanner rightX: rightX font: aFont<br>
+ "NB: strongly consider getting almost all these parameters from the scanner"<br>
+ "Since I'm a byte char string, I know that we have to scan single-byte characters and don't have to handle encodings etc"<br>
+ startIndex > stopIndex<br>
+ ifTrue: [^aCharacterScanner handleEndOfRunAt: stopIndex].<br>
+ ^aFont scanByteCharactersFrom: startIndex to: stopIndex in: self with: aCharacterScanner rightX: rightX!<br>
<br>
Item was added:<br>
+ ----- Method: WideString>>scanCharactersFrom:to:with:rightX:font: (in category 'character scanning') -----<br>
+ scanCharactersFrom: startIndex to: stopIndex with: aCharacterScanner rightX: rightX font: aFont<br>
+ "NB: strongly consider getting almost all these parameters from the scanner"<br>
+ "Since I'm a wide char string, I know that we have to scan multi-byte characters and handle encodings etc"<br>
+ | charSet |<br>
+ startIndex > stopIndex<br>
+ ifTrue: [^aCharacterScanner handleEndOfRunAt: stopIndex].<br>
+ charSet := self encodedCharSetAt: startIndex.<br>
+ ^charSet scanMultibyteCharactersFrom: startIndex to: stopIndex in: self with: aCharacterScanner rightX: rightX font: aFont !<br>
<br>
<br>
</blockquote></div><br></div>