<div dir="ltr">See Name: System-cmm.586<br><div id=":5j1">
- Factor SmalltalkImage>>#<span class="">unloadAllKnownPackages</span> into several smaller methods to allow more deliberate shrinking.<br></div><div id=":5j1">snip...<br><br></div><div id=":5j1">Note that MCMcmUpdater comment does still refer to this method.<br>
</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/12/13 Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 13 December 2013 12:57, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
> On Fri, Dec 13, 2013 at 07:42:28AM +0000, Frank Shearar wrote:<br>
>> On 12 December 2013 23:58, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
>> > David T. Lewis uploaded a new version of Collections to project The Trunk:<br>
>> > <a href="http://source.squeak.org/trunk/Collections-dtl.548.mcz" target="_blank">http://source.squeak.org/trunk/Collections-dtl.548.mcz</a><br>
>> ><br>
>> > ==================== Summary ====================<br>
>> ><br>
>> > Name: Collections-dtl.548<br>
>> > Author: dtl<br>
>> > Time: 12 December 2013, 6:58:08.878 pm<br>
>> > UUID: b167353b-b9ab-4911-8168-c5f184cab62a<br>
>> > Ancestors: Collections-ul.547<br>
>> ><br>
>> > Transcripter>>initInFrame: should do nothing when not in MVC<br>
>> ><br>
>> > =============== Diff against Collections-ul.547 ===============<br>
>> ><br>
>> > Item was changed:<br>
>> > ----- Method: Transcripter>>initInFrame: (in category 'initialization') -----<br>
>> > initInFrame: rect<br>
>> > + Smalltalk at: #Paragraph ifPresent: [:classParagraph | "MVC"<br>
>> > + frame := rect insetBy: 2. "Leave room for border"<br>
>> > + para := classParagraph withText: self contents asText<br>
>> > + style: TextStyle default<br>
>> > + compositionRectangle: ((frame insetBy: 4) withHeight: 9999)<br>
>> > + clippingRectangle: frame<br>
>> > + foreColor: self black backColor: self white]!<br>
>> > - frame := rect insetBy: 2. "Leave room for border"<br>
>> > - (Smalltalk hasClassNamed: #Paragraph)<br>
>> > - ifFalse: [^ self inform: 'MVC class Paragraph not present'].<br>
>> > - para := (Smalltalk at: #Paragraph) withText: self contents asText<br>
>> > - style: TextStyle default<br>
>> > - compositionRectangle: ((frame insetBy: 4) withHeight: 9999)<br>
>> > - clippingRectangle: frame<br>
>> > - foreColor: self black backColor: self white!<br>
>><br>
>> Well, that definitely stops a DNU and such when running in Morphic<br>
>> (yay!) but it still won't work in a non-MVC/Morphic world. That's when<br>
>> you accused me of overengineering, David :)<br>
><br>
> Yes you're right, I meant that with a smiley, sorry :)<br>
<br>
</div></div>I knew there was something of a smiley in there :) I just meant that<br>
if we want to preserve the Transcripter's emergencyEvaluator we would<br>
need this "complexity" because we'd need an emergencyEvaluator per UI<br>
framework.<br>
<div class="im"><br>
> I also made a mistake when I tested it, I didn't have MVC completely<br>
> unloaded. Hmmm, the unload procedure in #unloadReloadablePackages does<br>
> not seem to work, at least not if MVC projects exist in the image.<br>
><br>
> The full MVC removal used to be in #unloadAllKnownPackages, which is no<br>
> longer in the image. The MVC removal in #unloadReloadablePackages seems to<br>
> be focused only on removing code, not on doing the full removal. Presumably<br>
> that is the intent, but do we also have a method elsewhere that does what<br>
> #unloadAllKnownPackages used to do?<br>
<br>
</div>I can't remember now the who/when/what of #unloadAllKnownPackages's<br>
removal. I think I'd moaned about its references to things like ST80.<br>
At any rate, the images that CI use don't have ST80 in them, by virtue<br>
of a #unloadAllKnownPackages done long, long ago.<br>
<br>
frank<br>
<br>
> Dave<br>
<br>
</blockquote></div><br></div>