<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 13, 2013 at 7:08 AM, Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 13 December 2013 12:57, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
> On Fri, Dec 13, 2013 at 07:42:28AM +0000, Frank Shearar wrote:<br>
>> On 12 December 2013 23:58, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
>> > David T. Lewis uploaded a new version of Collections to project The Trunk:<br>
>> > <a href="http://source.squeak.org/trunk/Collections-dtl.548.mcz" target="_blank">http://source.squeak.org/trunk/Collections-dtl.548.mcz</a><br>
>> ><br>
>> > ==================== Summary ====================<br>
>> ><br>
>> > Name: Collections-dtl.548<br>
>> > Author: dtl<br>
>> > Time: 12 December 2013, 6:58:08.878 pm<br>
>> > UUID: b167353b-b9ab-4911-8168-c5f184cab62a<br>
>> > Ancestors: Collections-ul.547<br>
>> ><br>
>> > Transcripter>>initInFrame: should do nothing when not in MVC<br>
>> ><br>
>> > =============== Diff against Collections-ul.547 ===============<br>
>> ><br>
>> > Item was changed:<br>
>> > ----- Method: Transcripter>>initInFrame: (in category 'initialization') -----<br>
>> > initInFrame: rect<br>
>> > + Smalltalk at: #Paragraph ifPresent: [:classParagraph | "MVC"<br>
>> > + frame := rect insetBy: 2. "Leave room for border"<br>
>> > + para := classParagraph withText: self contents asText<br>
>> > + style: TextStyle default<br>
>> > + compositionRectangle: ((frame insetBy: 4) withHeight: 9999)<br>
>> > + clippingRectangle: frame<br>
>> > + foreColor: self black backColor: self white]!<br>
>> > - frame := rect insetBy: 2. "Leave room for border"<br>
>> > - (Smalltalk hasClassNamed: #Paragraph)<br>
>> > - ifFalse: [^ self inform: 'MVC class Paragraph not present'].<br>
>> > - para := (Smalltalk at: #Paragraph) withText: self contents asText<br>
>> > - style: TextStyle default<br>
>> > - compositionRectangle: ((frame insetBy: 4) withHeight: 9999)<br>
>> > - clippingRectangle: frame<br>
>> > - foreColor: self black backColor: self white!<br></div></div></blockquote><div><br></div><div>Dave, the only thing I don't like about this change is I thought we said we were going to migrate away from using the Dictionary API on Smalltalk. This was back when Andreas and community came up with the idea of the wrapped 'globals'.</div>
<div><br></div><div>I think it would be better to use</div><div><br></div><div> (Smalltalk classNamed: #Paragraph) ifNotNil: [ : classParagraph | ... ]</div><div> </div><div>otherwise we can never find all the places where we try to do logical access to class.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
>><br>
>> Well, that definitely stops a DNU and such when running in Morphic<br>
>> (yay!) but it still won't work in a non-MVC/Morphic world. That's when<br>
>> you accused me of overengineering, David :)<br>
><br>
> Yes you're right, I meant that with a smiley, sorry :)<br>
<br>
</div></div>I knew there was something of a smiley in there :) I just meant that<br>
if we want to preserve the Transcripter's emergencyEvaluator we would<br>
need this "complexity" because we'd need an emergencyEvaluator per UI<br>
framework.<br></blockquote><div><br></div><div>-1. Please be more conservative and lazy about putting new code/elements into the system. TSTTCPW demands that we don't start building out infrastructure for new UI frameworks until those frameworks are being pushed into existence and such a factoring is actually NEEDED. Please only write code for the "now" not for some "potential future". 10 years could go by with no new graphical frameworks and then someone looking at your class-hierarchy will regard it as "cruft".</div>
<div><br></div></div></div></div>