<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">2014/1/9 Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 9 January 2014 12:32, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Frank Shearar uploaded a new version of Tests to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Tests-fbs.285.mcz" target="_blank">http://source.squeak.org/trunk/Tests-fbs.285.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Tests-fbs.285<br>
> Author: fbs<br>
> Time: 9 January 2014, 12:32:14.059 pm<br>
> UUID: 8a2dc139-e417-ff40-8a02-1077909eff36<br>
> Ancestors: Tests-fbs.284<br>
><br>
> More "more descriptive errors" items: I missed these last time round.<br>
><br>
> =============== Diff against Tests-fbs.284 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: EnvironmentTest>>testUndeclare (in category 'binding tests') -----<br>
> testUndeclare<br>
> | one two |<br>
> one := env undeclare: #Griffle.<br>
> two := env bindingOf: #Griffle.<br>
> + self assert: two equals: one description: '#bindingOf: value doesn''t match that returned by #undeclare'.<br>
> - self assert: one == two description: '#bindingOf: value doesn''t match that returned by #undeclare'.<br></div></blockquote><div><br></div><div>asset:equals: or assert:identical: ?<br> <br></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
> self assert: Global equals: one class description: 'Type of binding'.<br>
> self assert: nil equals: one value description: 'Value of binding'.!<br>
<br>
</div>This test checks, among other things, that the binding of an<br>
undeclared thing is the same object as the object you got back when<br>
you undeclared it.<br>
<br>
That's not true at the moment: if you undeclare Griffle, #undeclare:<br>
returns the binding, and #bindingOf: then returns nil.<br>
<br>
We could make the test pass by removing the first assert (or better,<br>
replacing the line with " self assert: nil equals: two description:<br>
'#bindingOf:'."), but I thought it worth discussing first, before I<br>
did that.<br>
<span class="HOEnZb"><font color="#888888"><br>
frank<br>
<br>
</font></span></blockquote></div><br></div></div>