<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">2014-02-18 23:21 GMT+01:00 Frank Shearar <span dir="ltr"><<a href="mailto:frank.shearar@gmail.com" target="_blank">frank.shearar@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 17 February 2014 22:35, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Chris Muller uploaded a new version of Tests to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Tests-cmm.290.mcz" target="_blank">http://source.squeak.org/trunk/Tests-cmm.290.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Tests-cmm.290<br>
> Author: cmm<br>
> Time: 17 February 2014, 4:35:24.565 pm<br>
> UUID: f3fccfae-6baf-4093-ba62-e15ef110a687<br>
> Ancestors: Tests-cwp.289<br>
><br>
> Minor factoring.<br>
><br>
> =============== Diff against Tests-cwp.289 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: BlockLocalTemporariesRemovalTest>>assert:isChangedDuringParsingTo:withRemovalOfTemporariesNamed: (in category 'test helper') -----<br>
> + assert: someCode isChangedDuringParsingTo: someOtherCode withRemovalOfTemporariesNamed: someTempNames<br>
> - assert: someCode isChangedDuringParsingTo: someOtherCode withRemovalOfTemporariesNamed: someTempNames<br>
> -<br>
> | failBlock |<br>
> self sourceCode: someCode.<br>
> + failBlock := [ self fail ].<br>
> + [ self class<br>
> + compile: self sourceCode<br>
> + notifying: self<br>
> + trailer: self class defaultMethodTrailer<br>
> + ifFail: failBlock ]<br>
> - failBlock := [self fail].<br>
> - [self class<br>
> - compile: self sourceCode<br>
> - notifying: self<br>
> - trailer: self class defaultMethodTrailer<br>
> - ifFail: failBlock]<br>
> on: UnusedVariable<br>
> + do:<br>
> + [ : aNotification | aNotification openMenuIn:<br>
> + [ : options : emptyCollection : someText | aNotification resume:<br>
> + (someTempNames anySatisfy:<br>
> + [ : tempName | someText beginsWith: tempName ]) ] ].<br>
> - do: [:aNotification | aNotification<br>
> - openMenuIn: [:options :emptyCollection :someText |<br>
> - (someTempNames anySatisfy: [:tempName | someText startsWith: tempName])<br>
> - ifTrue: [aNotification resume: true]<br>
> - ifFalse: [aNotification resume: false]]].<br>
> self assert: self sourceCode = someOtherCode!<br>
<br>
</div></div>Seriously, we need a better differ. If we pretty-printed the before &<br>
after I'd at least stand a chance of not going blind trying to find<br>
the change here. How difficult a change is it to SS? Surely a<br>
one-liner, to someone who knows the codebase (i.e., not me).<br>
<span class="HOEnZb"><font color="#888888"><br>
frank<br>
<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Frank, in this case you have to trust the comment: minot refactoring<br>(ifTrue: [true] ifFalse: [false]), there must be something simpler indeed...<br>
</div></div>