<div dir="ltr">Hi Chris,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 5, 2014 at 11:17 AM, Chris Muller <span dir="ltr"><<a href="mailto:ma.chris.m@gmail.com" target="_blank">ma.chris.m@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Magma performance is definitely affected by #flush -- it takes care<br>
care to not flush more than once every 5 seconds.<br>
<br>
I want to research whether this will affect that..<br></blockquote><div><br></div><div>I doubt it very much. David's fix s to add a flush to nextChunkPut: and nextChunkPut: is used exclusively to write source code to sources/changes files.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Mon, May 5, 2014 at 11:48 AM, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
> On Sat, May 03, 2014 at 02:01:57PM -0400, David T. Lewis wrote:<br>
>> On Sat, May 03, 2014 at 11:18:11AM -0500, Chris Muller wrote:<br>
>> ><br>
>> > On Fri, May 2, 2014 at 4:38 PM, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
>> >><br>
>> >>><br>
>> >>> On Thu, Apr 10, 2014 at 10:06 AM, David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
>> >>>><br>
>> >>>>> On Wed, 09 Apr 2014 16:52:54 -0700 David T. Lewis <<a href="mailto:lewis@mail.msen.com">lewis@mail.msen.com</a>> wrote:<br>
>> >>>>>><br>
>> >>>>>> Create a new class, attempt to edit the class comment ==&gt; Error:<br>
>> >>>>>> RemoteString past end of file<br>
>> >>>>>><br>
>> >>>>>> Surely I cannot be the first person to have edited a class comment in<br>
>> >>>>>> the<br>
>> >>>>>> last month or so ... I hope.<br>
>> >>>>>><br>
>> >>>>><br>
>> >>>>> WriteStream>>nextChunkPut<br>
>> >>>>><br>
>> >>>>> add a self flush at the end will fix it.<br>
>> >>>>><br>
>> >>>>> Discussion several months ago fingered the gcc 4 compiler so something.<br>
>> >>>>><br>
>> >>>>> cheers.<br>
>> >>>>><br>
>> >>>>> tty<br>
>> >>>>><br>
>> >>>><br>
>> >>>> Ah, right, thank you! I do recall the discussion now that you mention it.<br>
>> >>>> I use VMs compiled on my own machine, which happens to be a new Ubuntu<br>
>> >>>> system at the moment. It probably has the buggy gcc library.<br>
>> >>>><br>
>> >>>> Thanks a lot,<br>
>> >>>> Dave<br>
>> >>>><br>
>> >>> Okay, I was just getting this again in our release image. Strange --<br>
>> >>> it happens on one laptop but not the other..! The suggested patch<br>
>> >>> seemed to work for me, don't we need to push this fix to trunk and<br>
>> >>> squeak45?<br>
>> >>><br>
>> >> I should double check to be sure, but I think this was a bug in the run<br>
>> >> time libraries of the operating system, as opposed to something in the VM<br>
>> >> or the image. I can't say I like the idea of putting a kludge into the<br>
>> >> image to work around a bug in Ubuntu, although it might be worthwhile in<br>
>> >> this case just to prevent new users from having a bad experience.<br>
>> >><br>
>> >> Come to think of it, we should be able to write a unit test that would<br>
>> >> detect this problem when running Squeak on a buggy OS.<br>
>> >><br>
>> >> Dave<br>
>> >><br>
>> > Strange I encountered the bug on Ubuntu 14.04 instead of 12.04 instead<br>
>> > of the other way around.. Actually not, Ubuntu seems to be getting<br>
>> > worse in some ways..<br>
>> ><br>
>><br>
>> I am having a hard time reducing this problem to something I can put into<br>
>> a unit test. I can't see any obvious problem in the way the writes are being<br>
>> performed on a file stream, and the actual failure seems to be happening<br>
>> when creating the initial RemoteStream for a class comment. When a new class<br>
>> is created without a class comment, the classComment in the ClassOrganizer<br>
>> is nil. When accepting a new comment in a browser for the first time, a<br>
>> RemoteStream is created to reference the comment that will be saved in the<br>
>> changes file. Something gets out of whack at that point, but I have not yet<br>
>> spotted the cause.<br>
><br>
> I pushed the fix^h^h^hworkaround for this to the inbox. I bothers me a bit that<br>
> I can't come up with a reproduceable test case for this, but the change seems<br>
> harmless.<br>
><br>
> If no objections, this will go into trunk.<br>
><br>
> Dave<br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>