<div dir="ltr">I think there have been complaints but not much have been done to it.<div><br></div><div>I'm not sure yet if this change breaks any other functionality.These widgets have quite complex behavior .</div><div>
<br></div><div><br></div><div>Karl </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 23, 2014 at 9:34 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ah, I see now. That's surprising; I'm suprised no one complained<br>
about that before..<br>
<div class="HOEnZb"><div class="h5"><br>
On Mon, Jun 23, 2014 at 12:15 PM, karl ramberg <<a href="mailto:karlramberg@gmail.com">karlramberg@gmail.com</a>> wrote:<br>
> Before this change, moving the mouse out of a text or list pane meant it<br>
> lost keyboard focus.<br>
> Even if the Preferences mouseOverForKeyboardFocus was false.<br>
> With this change you have to click the pane you want tho have keyboard<br>
> focus.<br>
><br>
> I find working with this change is less aggravating since I very often bump<br>
> the mouse out of small text boxes and panes.<br>
><br>
> It also means the preference does what it say it will do.<br>
><br>
> Karl<br>
><br>
><br>
> On Mon, Jun 23, 2014 at 5:18 PM, Chris Muller <<a href="mailto:asqueaker@gmail.com">asqueaker@gmail.com</a>> wrote:<br>
>><br>
>> Can you explain what effect this has for regular interaction with an<br>
>> image? It's not obvious to me.<br>
>><br>
>> On Sun, Jun 22, 2014 at 10:04 AM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
>> > A new version of Morphic was added to project The Inbox:<br>
>> > <a href="http://source.squeak.org/inbox/Morphic-kfr.722.mcz" target="_blank">http://source.squeak.org/inbox/Morphic-kfr.722.mcz</a><br>
>> ><br>
>> > ==================== Summary ====================<br>
>> ><br>
>> > Name: Morphic-kfr.722<br>
>> > Author: kfr<br>
>> > Time: 22 June 2014, 4:59:39.758 pm<br>
>> > UUID: fffb2b9e-3b71-f341-9042-4e35e7cc19fa<br>
>> > Ancestors: Morphic-cmm.721<br>
>> ><br>
>> > Make keyboard focus respect Preferences mouseOverForKeyboardFocus. With<br>
>> > this change one has to click for keyboard fokus.<br>
>> ><br>
>> > =============== Diff against Morphic-cmm.721 ===============<br>
>> ><br>
>> > Item was changed:<br>
>> > ----- Method: PluggableListMorph>>mouseUp: (in category 'events')<br>
>> > -----<br>
>> > mouseUp: event<br>
>> > "The mouse came up within the list; take appropriate action"<br>
>> > | row |<br>
>> > row := self rowAtLocation: event position.<br>
>> > "aMorph ifNotNil: [aMorph highlightForMouseDown: false]."<br>
>> > model okToChange<br>
>> > ifFalse: [^ self].<br>
>> > "No change if model is locked"<br>
>> > row = self selectionIndex<br>
>> > ifTrue: [(autoDeselect ifNil: [true]) ifTrue:[row = 0<br>
>> > ifFalse: [self changeModelSelection: 0] ]]<br>
>> > ifFalse: [self changeModelSelection: (self<br>
>> > modelIndexFor: row)].<br>
>> > + event hand newKeyboardFocus: self.<br>
>> > + hasFocus := true.<br>
>> > Cursor normal show!<br>
>> ><br>
>> > Item was changed:<br>
>> > ----- Method: ScrollPane>>handlesMouseOver: (in category 'event<br>
>> > handling') -----<br>
>> > handlesMouseOver: evt<br>
>> > "Could just ^ true, but this ensures that scroll bars won't flop<br>
>> > out<br>
>> > if you mouse-over appendages such as connecting pins."<br>
>> > self flag: #arNote. "I have no idea how the code below could've<br>
>> > ever worked. If the receiver does not handle mouse over events then it<br>
>> > should not receive any #mouseLeave if the mouse leaves the receiver for<br>
>> > real. This is because 'evt cursorPoint' describes the *end* point of the<br>
>> > movement and considering that the code would return false if the move ends<br>
>> > outside the receiver the scroll bars should never pop back in again. Which<br>
>> > is exactly what happens with the new event logic if you don't just ^true.<br>
>> > I'm leaving the code in for reference - perhaps somebody can make sense from<br>
>> > it; I sure cannot."<br>
>> > + ^Preferences mouseOverForKeyboardFocus<br>
>> > - ^true<br>
>> > "<br>
>> > | cp |<br>
>> > cp := evt cursorPoint.<br>
>> > (bounds containsPoint: cp)<br>
>> > ifTrue: [^ true]<br>
>> > ifFalse: [self submorphsDo:<br>
>> > [:m | (m containsPoint: cp)<br>
>> > ifTrue:<br>
>> > [m == scrollBar<br>
>> > ifTrue:<br>
>> > [^ true]<br>
>> > ifFalse:<br>
>> > [^ false]]].<br>
>> > ^ false]<br>
>> > "!<br>
>> ><br>
>> ><br>
>><br>
><br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>