<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Chris,</div><div><br>On Jul 7, 2014, at 5:42 PM, Chris Muller <<a href="mailto:asqueaker@gmail.com">asqueaker@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div><br></div><div>I think forcing a double-blink for every possible use-case for #flash won't work. Plus, an arbitrary 50ms delay will not let anyone be happy because some want absolutely no blockage while others wanted more than 50ms..<br>
</div><div><br></div><div>#flashStyle or #flashIntensity preference would be one way to address those differences.</div></div></div></blockquote><div><br></div><div><br></div>It's a hack. It complicates without adding anything. Perceptually, a flash needs to last something like a 1/10th if a second to be easily visible. Clearly a simple reverse won't work. Bert has explained that using alarms, rather than delays, can implement flash without blocking. Surely we can do the right thing here and implement flash having a consistent duration and not blocking?<div><br></div><div><br><blockquote type="cite"><div><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 3, 2014 at 7:29 AM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A new version of Morphic was added to project The Inbox:<br>
<a href="http://source.squeak.org/inbox/Morphic-kfr.731.mcz" target="_blank">http://source.squeak.org/inbox/Morphic-kfr.731.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-kfr.731<br>
Author: kfr<br>
Time: 3 July 2014, 2:28:57.179 pm<br>
UUID: 05ec5d84-8101-f94b-847f-d4e467ddeead<br>
Ancestors: Morphic-kfr.730<br>
<br>
Small fix for keyboard focus.<br>
Double flash for morph implementation<br>
<br>
=============== Diff against Morphic-cmm.729 ===============<br>
<br>
Item was changed:<br>
----- Method: AlternatePluggableListMorphOfMany>>mouseUp: (in category 'event handling') -----<br>
mouseUp: event<br>
+<br>
+ event hand newKeyboardFocus: self.<br>
+ hasFocus := true.<br>
+ ^self!<br>
- "Not needed. Overridden to do nothing."!<br>
<br>
Item was changed:<br>
----- Method: Morph>>flash (in category 'macpal') -----<br>
flash<br>
+ "Flash me"<br>
| originalColor |<br>
originalColor := self color.<br>
+ 1<br>
+ to: 2<br>
+ do: [:i | [self<br>
+ color: (originalColor<br>
+ ifNil: [Color black]<br>
+ ifNotNil: [((originalColor alpha: 1)<br>
+ adjustSaturation: 0.8<br>
+ brightness: 0) negated])]<br>
+ ensure: [self world<br>
+ ifNotNil: [:w | w displayWorldSafely].<br>
+ (Delay forMilliseconds: 50) wait.<br>
+ [self color: originalColor]<br>
+ ensure: [self world<br>
+ ifNotNil: [:w | w displayWorldSafely].<br>
+ (Delay forMilliseconds: 50) wait]]]!<br>
- [ self color:<br>
- (originalColor<br>
- ifNil: [ Color black ]<br>
- ifNotNil: [( (originalColor alpha: 1) adjustSaturation: 0.8 brightness: 0) negated ]) ]<br>
- ensure:<br>
- [ self world ifNotNil: [ : w | w displayWorldSafely ].<br>
- self color: originalColor ]!<br>
<br>
Item was changed:<br>
----- Method: TextMorphForEditView>>mouseDown: (in category 'event handling') -----<br>
mouseDown: event<br>
<br>
event yellowButtonPressed ifTrue: [<br>
+ (self editor yellowButtonDown: event) ifTrue:[^self].<br>
- (editor yellowButtonDown: event) ifTrue:[^self].<br>
^ editView yellowButtonActivity: event shiftPressed].<br>
^ super mouseDown: event<br>
!<br>
<br>
<br>
</blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span></span><br></div></blockquote></div></body></html>