<div dir="ltr">Hi Karl,<div><br></div><div> worry not. It is simply that the image that does the differencing hasn't been updated and so barfs on Spur's Character class definition:</div><div><br></div><div><div>
Magnitude immediateSubclass: #Character</div><div><span class="" style="white-space:pre">        </span>instanceVariableNames: ''</div><div><span class="" style="white-space:pre">        </span>classVariableNames: 'CharacterTable ClassificationTable DigitValues LetterBits LowercaseBit UppercaseBit'</div>
<div><span class="" style="white-space:pre">        </span>poolDictionaries: ''</div><div><span class="" style="white-space:pre">        </span>category: 'Collections-Strings'</div></div><div><br></div><div>immediateSubclass: is new with Spur, support for which is in trunk. Now that there are two immediate subclasses and we're likely to have a third in the 64-bit system some time next year (SmallFloat) it seemed to me better to introduce the selector and avoid using the old hack which presents SmallInteger as if it is a normal class and needs hidden chicanery in the ClassBuilder to allow it to be redefined.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 17, 2014 at 2:39 PM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eliot Miranda uploaded a new version of Collections to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Collections.spur-ul.573.mcz" target="_blank">http://source.squeak.org/trunk/Collections.spur-ul.573.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Collections.spur-ul.573<br>
Author: eem<br>
Time: 17 July 2014, 2:37:48.485 pm<br>
UUID: e0223be3-5368-4070-9468-66be709d489c<br>
Ancestors: Collections-ul.573<br>
<br>
Collections-ul.573 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.168<br>
<br>
Character changes<br>
- introduced #encodedCharSet to access the EncodedCharSet of a character<br>
- all methods use #encodedCharSet instead of (EncodedCharSet charSetAt: self leadingChar)<br>
- #isAlphaNumeric uses the EncodedCharSet class's #isAlphaNumeric: method<br>
<br>
=============== Diff against Collections-ul.573 ===============<br>
<br>
Item was changed:<br>
==== ERROR ===<br>
<br>
Error: Unrecognized class type<br>
<br>
17 July 2014 9:39:45.17 pm<br>
<br>
VM: unix - a SmalltalkImage<br>
Image: Squeak3.11alpha [latest update: #8824]<br>
<br>
SecurityManager state:<br>
Restricted: false<br>
FileAccess: true<br>
SocketAccess: true<br>
Working Dir /home/squeaksource<br>
Trusted Dir /home/squeaksource/secure<br>
Untrusted Dir /home/squeaksource/My Squeak<br>
<br>
MCClassDefinition(Object)>>error:<br>
Receiver: a MCClassDefinition(Character)<br>
Arguments and temporary variables:<br>
aString: 'Unrecognized class type'<br>
Receiver's instance variables:<br>
name: #Character<br>
superclassName: #Magnitude<br>
variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
category: #'Collections-Strings'<br>
type: #immediate<br>
comment: 'I represent a character by storing its associated Unicode. The first ...etc...<br>
commentStamp: 'ar 4/9/2005 22:35'<br>
traitComposition: nil<br>
classTraitComposition: nil<br>
<br>
MCClassDefinition>>kindOfSubclass<br>
Receiver: a MCClassDefinition(Character)<br>
Arguments and temporary variables:<br>
<br>
Receiver's instance variables:<br>
name: #Character<br>
superclassName: #Magnitude<br>
variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
category: #'Collections-Strings'<br>
type: #immediate<br>
comment: 'I represent a character by storing its associated Unicode. The first ...etc...<br>
commentStamp: 'ar 4/9/2005 22:35'<br>
traitComposition: nil<br>
classTraitComposition: nil<br>
<br>
MCClassDefinition>>printDefinitionOn:<br>
Receiver: a MCClassDefinition(Character)<br>
Arguments and temporary variables:<br>
stream: a WriteStream<br>
Receiver's instance variables:<br>
name: #Character<br>
superclassName: #Magnitude<br>
variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
category: #'Collections-Strings'<br>
type: #immediate<br>
comment: 'I represent a character by storing its associated Unicode. The first ...etc...<br>
commentStamp: 'ar 4/9/2005 22:35'<br>
traitComposition: nil<br>
classTraitComposition: nil<br>
<br>
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
Receiver: a MCDiffyTextWriter<br>
Arguments and temporary variables:<br>
definition: a WriteStream<br>
s: a MCClassDefinition(Character)<br>
Receiver's instance variables:<br>
stream: a WriteStream<br>
initStream: nil<br>
<br>
<br>
--- The full stack ---<br>
MCClassDefinition(Object)>>error:<br>
MCClassDefinition>>kindOfSubclass<br>
MCClassDefinition>>printDefinitionOn:<br>
[] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -<br>
String class(SequenceableCollection class)>>new:streamContents:<br>
String class(SequenceableCollection class)>>streamContents:<br>
MCDiffyTextWriter(MCTextWriter)>>chunkContents:<br>
MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:<br>
MCClassDefinition>>accept:<br>
[] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:<br>
String class(SequenceableCollection class)>>new:streamContents:<br>
String class(SequenceableCollection class)>>streamContents:<br>
MCDiffyTextWriter(MCTextWriter)>>visitInFork:<br>
MCDiffyTextWriter>>writePatchFrom:to:<br>
MCDiffyTextWriter>>writeModification:<br>
[] in MCDiffyTextWriter>>writePatch:<br>
SortedCollection(OrderedCollection)>>do:<br>
MCDiffyTextWriter>>writePatch:<br>
SSDiffyTextWriter>>writePatch:<br>
[] in SSDiffyTextWriter>>writeVersion:for:<br>
BlockClosure>>on:do:<br>
SSDiffyTextWriter>>writeVersion:for:<br>
[] in SSEMailSubscription>>versionAdded:to:<br>
BlockClosure>>on:do:<br>
SSEMailSubscription>>versionAdded:to:<br>
[] in [] in SSProject>>versionAdded:<br>
[] in BlockClosure>>newProcess<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div>