<div dir="ltr">Hey Karl, would you like to repost your changes to the Inbox? Some of them still had too little consensus to go into trunk, but the other ones I couldn't diff, sorry. Let's route them back through Inbox and discuss and watch it closely see if that ancestry issue or empty package pops up again..<div>
<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Jul 31, 2014 at 1:54 PM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Chris Muller uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-cmm.730.mcz" target="_blank">http://source.squeak.org/trunk/Morphic-cmm.730.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-cmm.730<br>
Author: cmm<br>
Time: 31 July 2014, 1:54:13.695 pm<br>
UUID: 51d16b4a-f89e-4a51-9a6a-5647a4cde024<br>
Ancestors: Morphic-kfr.729<br>
<br>
There are some issues with recent Morphic packages:<br>
<br>
- 730 is missing its log message and from trunk.<br>
- 731 is entirely missing from trunk repository and inbox. It was moved to treated after flash discussion it should not be in trunk ancestry.<br>
- 732 is an empty mcz.<br>
- 733 broke color rendering in multi-select lists.<br>
<br>
I've loaded back to Morphic-kfr.729 and merged the changes from 736-737, but not 730-733 because of the problems.<br>
<br>
=============== Diff against Morphic-kfr.729 ===============<br>
<br>
Item was changed:<br>
----- Method: MorphicProject class>>compileNewDefaultBackgroundFrom: (in category 'utilities') -----<br>
compileNewDefaultBackgroundFrom: aForm<br>
"Compile a new #defaultBackgroundForm method in this class-side which uses aForm as the background."<br>
+ | formStream base64 |<br>
+ formStream := ByteArray new writeStream.<br>
- | formStream base64Stream |<br>
- formStream := RWBinaryOrTextStream on: ByteArray new.<br>
PNGReadWriter<br>
putForm: aForm<br>
onStream: formStream.<br>
+ base64 := formStream base64Encoded.<br>
- base64Stream := Base64MimeConverter mimeEncode: formStream.<br>
self class<br>
compile:<br>
(String streamContents:<br>
[ : stream | stream<br>
nextPutAll: 'defaultBackgroundForm<br>
^ Form fromBinaryStream: ' ;<br>
nextPut: $' ;<br>
+ nextPutAll: base64 ;<br>
- nextPutAll: base64Stream contents ;<br>
nextPut: $' ;<br>
nextPutAll: ' base64Decoded asByteArray readStream' ])<br>
classified: 'class initialization'!<br>
<br>
Item was changed:<br>
----- Method: TextEditor>>selectionAsStream (in category 'accessing-selection') -----<br>
selectionAsStream<br>
"Answer a ReadStream on the text in the paragraph that is currently selected."<br>
<br>
+ ^ReadStream<br>
- ^ReadWriteStream<br>
on: paragraph string<br>
from: self startIndex<br>
to: self stopIndex - 1!<br>
<br>
<br>
</blockquote></div><br></div>