<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2014-09-16 20:08 GMT+02:00 Tobias Pape <span dir="ltr"><<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
<br>
On 16.09.2014, at 19:19, Nicolas Cellier <<a href="mailto:nicolas.cellier.aka.nice@gmail.com">nicolas.cellier.aka.nice@gmail.com</a>> wrote:<br>
<br>
> Nice catch indeed.<br>
<br>
Wasn't me, but some of our students.<br>
They also found the dormant mantis entry…<br>
I have no Idea why it works, to be honest.<br>
<span class=""><br>
> But, ouch!<br>
> (self left @ self top) ~= self topLeft...<br>
> Without looking at the code, it sounds like heresy!<br>
> Wouldn't the real fix be to name a cat a cat? (a corner a corner in this case).<br>
<br>
</span>Yes, it would.<br>
<span class=""><br>
><br>
> After a brief look at the code, of course things are not so simple.<br>
> I'm not sure I completely understand the contracts, but inside the owner rectangular area, there are only some portions available for displaying text, and top answers the topMostAvailableDisplayArea...<br>
> This fake insulate some users of top from the knowledge of this availableAreaForDisplay feature which sounds like a good thing...<br>
> But in the same time, it fakes the innocent users of topLeft expecting top+left=topLeft.<br>
> No matter the di initials (sorry to scratch an icon), but IMO it's a well too sophisticated hack, and such hacks inevitably leads to such bugs.<br>
><br>
> As why we do not apply such ingeniosity to left, it's above my current understanding.<br>
><br>
><br>
<br>
</span>I found that that container (as per some Class comment) can be a TextContainer _or_ a Rectangle.<br>
And they apparently do different things on topLeft vs top @ left.<br>
I have no idea :)<br>
<br>
I had to convince myself again (I got the report 2month ago) that it indeed is the fix necessary…<br>
<br>
Lets call a cat a cat.<br>
Right after we fixed all the other stuff<br>
<span class=""><br>
><br>
><br>
> 2014-09-16 17:29 GMT+02:00 Frank Shearar <<a href="mailto:frank.shearar@gmail.com">frank.shearar@gmail.com</a>>:<br>
> On 16 September 2014 16:16, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> > Tobias Pape uploaded a new version of Graphics to project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/Graphics-topa.301.mcz" target="_blank">http://source.squeak.org/trunk/Graphics-topa.301.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: Graphics-topa.301<br>
> > Author: topa<br>
> > Time: 16 September 2014, 5:16:44.215 pm<br>
> > UUID: a66aac86-031b-4db4-97ce-e33376745f9e<br>
> > Ancestors: Graphics-mt.300<br>
> ><br>
> > Fix Mantis 5711<br>
> > <a href="http://bugs.squeak.org/view.php?id=5711" target="_blank">http://bugs.squeak.org/view.php?id=5711</a><br>
> > after 7 years...<br>
> ><br>
> > =============== Diff against Graphics-mt.300 ===============<br>
><br>
> Don't forget to tell Mantis that :)<br>
<br>
</span>Can Frank or Nicolas do that please? I cannot.<br>
<br>
<br>
<br>
Best<br>
<span class="HOEnZb"><font color="#888888"> -Tobias<br>
</font></span><br></blockquote><div> </div><div>Done,<br>But who could grant you more priviledges?<br></div></div><br></div></div>