<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 9, 2014 at 1:05 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">"==== ERROR ===<br>
<br>
Error: Unrecognized class type"<br>
<br>
</span>is a little disconcerting..<br></blockquote><div><br></div><div>Try it in a Spur image. Try it in an updated trunk image. You'll find no crash, and you'll find the class type is appropriate. Here's the diff from an updated trunk v3 (non-spur) image:</div><div><br></div><div><div>Magnitude <u>immediateSubclass:</u><i>subclass:</i> #Character</div><div><span class="" style="white-space:pre"> </span>instanceVariableNames: '<i>value</i>'</div><div><span class="" style="white-space:pre"> </span>classVariableNames: 'CharacterTable ClassificationTable DigitValues LetterBits LowercaseBit UppercaseBit'</div><div><span class="" style="white-space:pre"> </span>poolDictionaries: ''</div><div><span class="" style="white-space:pre"> </span>category: 'Collections-Strings'</div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
On Thu, Oct 9, 2014 at 12:44 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Eliot Miranda uploaded a new version of Collections to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Collections.spur-ul.584.mcz" target="_blank">http://source.squeak.org/trunk/Collections.spur-ul.584.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Collections.spur-ul.584<br>
> Author: eem<br>
> Time: 9 October 2014, 10:43:11.427 am<br>
> UUID: 73af4851-d240-41c0-89bd-6360f25f91d3<br>
> Ancestors: Collections-ul.584, Collections.spur-nice.583<br>
><br>
> Collections-ul.584 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.209<br>
><br>
> Character changes:<br>
> - use the value instance variable instead of #asciiValue where possible<br>
> - implemented #<= and #>=<br>
><br>
> =============== Diff against Collections-ul.584 ===============<br>
><br>
> Item was changed:<br>
> ==== ERROR ===<br>
><br>
> Error: Unrecognized class type<br>
><br>
> 9 October 2014 5:46:13.493 pm<br>
><br>
> VM: unix - a SmalltalkImage<br>
> Image: Squeak3.11alpha [latest update: #8824]<br>
><br>
> SecurityManager state:<br>
> Restricted: false<br>
> FileAccess: true<br>
> SocketAccess: true<br>
> Working Dir /home/squeaksource<br>
> Trusted Dir /home/squeaksource/secure<br>
> Untrusted Dir /home/squeaksource/My Squeak<br>
><br>
> MCClassDefinition(Object)>>error:<br>
> Receiver: a MCClassDefinition(Character)<br>
> Arguments and temporary variables:<br>
> aString: 'Unrecognized class type'<br>
> Receiver's instance variables:<br>
> name: #Character<br>
> superclassName: #Magnitude<br>
> variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
> category: #'Collections-Strings'<br>
> type: #immediate<br>
> comment: 'I represent a character by storing its associated Unicode as an unsig...etc...<br>
> commentStamp: 'eem 8/12/2014 14:53'<br>
> traitComposition: nil<br>
> classTraitComposition: nil<br>
><br>
> MCClassDefinition>>kindOfSubclass<br>
> Receiver: a MCClassDefinition(Character)<br>
> Arguments and temporary variables:<br>
><br>
> Receiver's instance variables:<br>
> name: #Character<br>
> superclassName: #Magnitude<br>
> variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
> category: #'Collections-Strings'<br>
> type: #immediate<br>
> comment: 'I represent a character by storing its associated Unicode as an unsig...etc...<br>
> commentStamp: 'eem 8/12/2014 14:53'<br>
> traitComposition: nil<br>
> classTraitComposition: nil<br>
><br>
> MCClassDefinition>>printDefinitionOn:<br>
> Receiver: a MCClassDefinition(Character)<br>
> Arguments and temporary variables:<br>
> stream: a WriteStream<br>
> Receiver's instance variables:<br>
> name: #Character<br>
> superclassName: #Magnitude<br>
> variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc...<br>
> category: #'Collections-Strings'<br>
> type: #immediate<br>
> comment: 'I represent a character by storing its associated Unicode as an unsig...etc...<br>
> commentStamp: 'eem 8/12/2014 14:53'<br>
> traitComposition: nil<br>
> classTraitComposition: nil<br>
><br>
> [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
> Receiver: a MCDiffyTextWriter<br>
> Arguments and temporary variables:<br>
> definition: a WriteStream<br>
> s: a MCClassDefinition(Character)<br>
> Receiver's instance variables:<br>
> stream: a WriteStream<br>
> initStream: nil<br>
><br>
><br>
> --- The full stack ---<br>
> MCClassDefinition(Object)>>error:<br>
> MCClassDefinition>>kindOfSubclass<br>
> MCClassDefinition>>printDefinitionOn:<br>
> [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -<br>
> String class(SequenceableCollection class)>>new:streamContents:<br>
> String class(SequenceableCollection class)>>streamContents:<br>
> MCDiffyTextWriter(MCTextWriter)>>chunkContents:<br>
> MCDiffyTextWriter(MCStWriter)>>writeClassDefinition:<br>
> MCDiffyTextWriter(MCStWriter)>>visitClassDefinition:<br>
> MCClassDefinition>>accept:<br>
> [] in MCDiffyTextWriter(MCTextWriter)>>visitInFork:<br>
> String class(SequenceableCollection class)>>new:streamContents:<br>
> String class(SequenceableCollection class)>>streamContents:<br>
> MCDiffyTextWriter(MCTextWriter)>>visitInFork:<br>
> MCDiffyTextWriter>>writePatchFrom:to:<br>
> MCDiffyTextWriter>>writeModification:<br>
> [] in MCDiffyTextWriter>>writePatch:<br>
> SortedCollection(OrderedCollection)>>do:<br>
> MCDiffyTextWriter>>writePatch:<br>
> SSDiffyTextWriter>>writePatch:<br>
> [] in SSDiffyTextWriter>>writeVersion:for:<br>
> BlockClosure>>on:do:<br>
> SSDiffyTextWriter>>writeVersion:for:<br>
> [] in SSEMailSubscription>>versionAdded:to:<br>
> BlockClosure>>on:do:<br>
> SSEMailSubscription>>versionAdded:to:<br>
> [] in [] in SSProject>>versionAdded:<br>
> [] in BlockClosure>>newProcess<br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>best,<div>Eliot</div>
</div></div>