<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Hi Nicolai,</div><div><br>On Nov 28, 2014, at 4:01 PM, Nicolai Hess <<a href="mailto:nicolaihess@web.de">nicolaihess@web.de</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-11-28 16:39 GMT+01:00 Marcus Denker <span dir="ltr"><<a href="mailto:marcus.denker@inria.fr" target="_blank">marcus.denker@inria.fr</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Nov 28, 2014 at 4:26 PM, Sven Van Caekenberghe <span dir="ltr"><<a href="mailto:sven@stfx.eu" target="_blank">sven@stfx.eu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><br>
> On 28 Nov 2014, at 15:35, Marcus Denker <<a href="mailto:marcus.denker@inria.fr" target="_blank">marcus.denker@inria.fr</a>> wrote:<br>
><br>
><br>
>> On 27 Nov 2014, at 08:21, Marcus Denker <<a href="mailto:marcus.denker@inria.fr" target="_blank">marcus.denker@inria.fr</a>> wrote:<br>
>><br>
>><br>
>>> On 26 Nov 2014, at 19:19, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:<br>
>>><br>
>>> Hi All,<br>
>>><br>
>>> IdentitySet>>collect: answers a Set, not an IdentitySet. Anyone else agree this is a serious bug? Anyone else disagree?<br>
>>><br>
>>> WTF??<br>
>>><br>
>>> (IdentitySet withAll: #(1 2 3 1.0 2.0 3.0)) collect: [:e| e] a Set(1.0 2 3)<br>
>><br>
>> Yes, I would say so. I think we fixed some others like that already (not 100% sure)<br>
>><br>
>> I added an issue tracker entry<br>
>><br>
>> 14535 IdentitySet>>collect: answers a Set, not an IdentitySet.<br>
>> <a href="https://pharo.fogbugz.com/f/cases/14535" target="_blank">https://pharo.fogbugz.com/f/cases/14535</a><br>
>><br>
><br>
> #collect: directly uses Set in Set>>#collect, I committed a fix (to the issue tracker, to be reviewed)<br>
> to use “self species” instead (plus the example from above as a test in IdentitySetTest).<br>
><br>
> Marcus<br>
<br>
</div></div>I think that is the most logical thing to do, it is what I would expect.<br>
<br>
I know others have cases where that is not really what you want (some of Set's subclasses are pretty special), but it is still a good default, while #collect:as: can be used for all other cases (and subclasses can override #species again if they want).<br>
<span><font color="#888888"><br></font></span></blockquote><div><br></div></div></div><div>Hmm... errors found by the test runner on that change.</div><div><br></div><div><a href="https://ci.inria.fr/pharo/job/Pharo-4.0-Issue-Validator/17683//artifact/validationReport.html" target="_blank">https://ci.inria.fr/pharo/job/Pharo-4.0-Issue-Validator/17683//artifact/validationReport.html</a><br></div><div><br></div><div>So we will need to check... </div><span class=""><font color="#888888"><div> </div></font></span></div><span class=""><font color="#888888"><div> Marcus</div>
</font></span></div></div>
</blockquote></div><br><br></div><div class="gmail_extra">In pharo, the problem is the OCKeyedSet, but the same happens in squeak with a KeyedSet.<br></div><div class="gmail_extra">Changing Set>>#collect: to use "self species new" the following code fails:<br><br>k:=KeyedSet new keyBlock:[:e | e name].<br>k addAll:{ Color red . Color blue . Color green}.<br>k collect:[:e | e ].<br>--> MessageNotUnderstood: Color>>key<br></div></div></div></blockquote><br><div>And if you implement species in KeyedSet to answer Set (which should fix this one issue) does anything else break?<br style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><br style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); "><span style="-webkit-tap-highlight-color: rgba(26, 26, 26, 0.296875); -webkit-composition-fill-color: rgba(175, 192, 227, 0.230469); -webkit-composition-frame-color: rgba(77, 128, 180, 0.230469); ">Eliot (phone)</span></div></body></html>