<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 9, 2014 at 12:36 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tue, Dec 9, 2014 at 8:02 AM, Craig Latta <<a href="mailto:craig@netjam.org">craig@netjam.org</a>> wrote:<br>
><br>
>> Do your pool references end up being valid?<br>
><br>
> Aha, the answer is no. So, I had to put some things in a separate<br>
> package which must be loaded first. Among those things is a change<br>
> required by a remote-object-aware version of<br>
> IdentityDictionary>>scanFor:; the system was crashing when they were<br>
> loaded in the wrong order.<br>
<br>
</span>Interesting. What did you have to do to #scanFor:, some kind of proxy<br>
detection or something?<br>
<br>
PS -- I agree with Eliot that MC _should_ handle compiling subclasses<br>
of SharedPool first. I thought it did..<br></blockquote><div><br></div><div>No, right now only methodAdditions are handled first. Look at MCPackageLoader>>basicLoad which is aching to be refactored to pull the exception handlers out. It should look like</div><div><br></div><div><div>basicLoad</div><div><span class="" style="white-space:pre"> </span>"Load the contents of some package. This is the core loading method</div><div><span class="" style="white-space:pre"> </span>in Monticello. Be wary about modifying it unless you understand the details</div><div><span class="" style="white-space:pre"> </span>and dependencies of the various entities being modified."</div><div><span class="" style="white-space:pre"> </span>RecentMessages default suspendWhile:</div><div><span class="" style="white-space:pre"> </span>[[CurrentReadOnlySourceFiles cacheDuring:</div><div><span class="" style="white-space:pre"> </span>[[self innerBasicLoad]</div><div><span class="" style="white-space:pre"> </span>on: InMidstOfFileinNotification</div><div><span class="" style="white-space:pre"> </span>do: [:n | n resume: true]]]</div><div><span class="" style="white-space:pre"> </span>ensure: [self flushChangesFile]]</div></div></div><br clear="all"><div><div>innerBasicLoad</div><div><span class="" style="white-space:pre"> </span>"Load the contents of some package. This is the core loading method</div><div><span class="" style="white-space:pre"> </span>in Monticello. Be wary about modifying it unless you understand the details</div><div><span class="" style="white-space:pre"> </span>and dependencies of the various entities being modified."</div><div><span class="" style="white-space:pre"> </span>| pkgName |</div><div><span class="" style="white-space:pre"> </span>errorDefinitions := OrderedCollection new.</div><div><span class="" style="white-space:pre"> </span>"Obviously this isn't the package name but we don't have anything else</div><div><span class="" style="white-space:pre"> </span>to use here. ChangeSet current name will generally work since a CS is </div><div><span class="" style="white-space:pre"> </span>usually installed prior to installation."</div><div><span class="" style="white-space:pre"> </span>pkgName := ChangeSet current name.</div><div><span class="" style="white-space:pre"> </span>preamble ifNotNil:</div><div><span class="" style="white-space:pre"> </span>[ChangeSet current preambleString: (self preambleAsCommentNamed: pkgName)].</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Pass 1: Load everything but the methods, which are collected in methodAdditions."</div><div><span class="" style="white-space:pre"> </span>additions</div><div><span class="" style="white-space:pre"> </span>do: [:ea | </div><div><span class="" style="white-space:pre"> </span>ea isMethodDefinition </div><div><span class="" style="white-space:pre"> </span>ifTrue: [methodAdditions add: ea asMethodAddition]</div><div><span class="" style="white-space:pre"> </span>ifFalse:</div><div><span class="" style="white-space:pre"> </span>[[ea load]</div><div><span class="" style="white-space:pre"> </span>on: Error</div><div><span class="" style="white-space:pre"> </span>do: [errorDefinitions add: ea]]]</div><div><span class="" style="white-space:pre"> </span>displayingProgress: 'Reshaping ', pkgName.</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Try again any delayed definitions"</div><div><span class="" style="white-space:pre"> </span>self shouldWarnAboutErrors ifTrue:</div><div><span class="" style="white-space:pre"> </span>[self warnAboutErrors].</div><div><span class="" style="white-space:pre"> </span>errorDefinitions do: [:ea | ea load] </div><div><span class="" style="white-space:pre"> </span>displayingProgress: 'Reloading ', pkgName.</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Pass 2: We compile new / changed methods"</div><div><span class="" style="white-space:pre"> </span>methodAdditions</div><div><span class="" style="white-space:pre"> </span>do: [:ea| ea createCompiledMethod] </div><div><span class="" style="white-space:pre"> </span>displayingProgress: 'Compiling ', pkgName.</div><div><br></div><div><span class="" style="white-space:pre"> </span>'Installing ', pkgName</div><div><span class="" style="white-space:pre"> </span>displayProgressFrom: 0</div><div><span class="" style="white-space:pre"> </span>to: 2</div><div><span class="" style="white-space:pre"> </span>during:</div><div><span class="" style="white-space:pre"> </span>[:bar|</div><div><span class="" style="white-space:pre"> </span>"There is no progress *during* installation since a progress bar update</div><div><span class="" style="white-space:pre"> </span>will redraw the world and potentially call methods that we're just trying to install."</div><div><span class="" style="white-space:pre"> </span>bar value: 1.</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Pass 3: Install the new / changed methods</div><div><span class="" style="white-space:pre"> </span>(this is a separate pass to allow compiler changes to be loaded)"</div><div><span class="" style="white-space:pre"> </span>methodAdditions do:</div><div><span class="" style="white-space:pre"> </span>[:ea| ea installMethod].</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Pass 4: Remove the obsolete methods"</div><div><span class="" style="white-space:pre"> </span>removals do:</div><div><span class="" style="white-space:pre"> </span>[:ea| ea unload]].</div><div><br></div><div><span class="" style="white-space:pre"> </span>"Finally, notify observers for the method additions"</div><div><span class="" style="white-space:pre"> </span>methodAdditions</div><div><span class="" style="white-space:pre"> </span>do: [:each | each notifyObservers] </div><div><span class="" style="white-space:pre"> </span>"the message is fake but actually telling people how much time we spend</div><div><span class="" style="white-space:pre"> </span>in the notifications is embarrassing so lie instead"</div><div><span class="" style="white-space:pre"> </span>displayingProgress: 'Installing ', pkgName.</div><div><br></div><div><span class="" style="white-space:pre"> </span>additions</div><div><span class="" style="white-space:pre"> </span>do: [:ea | ea postloadOver: (self obsoletionFor: ea)] </div><div><span class="" style="white-space:pre"> </span>displayingProgress: 'Initializing ', pkgName</div></div><div><br></div><div>But I have to say that I don't understand how basicLoad/innerBasicLoad sorts things. Confusing. Anyway, looks like the "Pass 1: Load everything but the methods, which are collected in methodAdditions." pass needs to be split into something that loads things that inherit from SharedPool first.</div><div><br></div>-- <br><div class="gmail_signature">best,<div>Eliot</div></div>
</div></div>