<div dir="ltr">Now I remember why I quit comitting to Squeak,<div><br></div><div><br></div><div>Bye</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Jan 10, 2015 at 10:31 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I strongly object to this change! I use this feature everytime I<br>
start a base image, but now you've introduced an unnecessary and<br>
horribly-hard-to-use modal UI interaction to something that,<br>
previously, could be done in one-click or non-interactively via<br>
script. I'm sorry, but this is utterly *awful* and, wrong-headed in<br>
the first place. There is now no quick and easy way to transfer of<br>
personal preferences from one image to another -- I have to click 57<br>
times instead of 1. No way.<br>
<br>
Please put it back the way it was and let's talk about what you want<br>
to do and work out an amicable way of doing it before slamming such a<br>
thing into trunk.<br>
<br>
My guess is you want to have multiple .prefs files. Maybe we need a<br>
new button for that. Or, how about holding the Shift key when<br>
clicking "load from disk" as a way to tell it to pop up your<br>
file-selection dialog?<br>
<br>
PS -- Plus, you forgot to put a log message in the version and now its<br>
part of trunk. Please always include a log message explaining "why"<br>
(not "what") the change is being made.<br>
<div class="HOEnZb"><div class="h5"><br>
On Fri, Jan 9, 2015 at 6:58 AM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Karl Ramberg uploaded a new version of System to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/System-kfr.693.mcz" target="_blank">http://source.squeak.org/trunk/System-kfr.693.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: System-kfr.693<br>
> Author: kfr<br>
> Time: 2 January 2015, 8:41:05.888 pm<br>
> UUID: 760e94c5-2386-f642-a545-55a1fe293351<br>
> Ancestors: System-bf.692<br>
><br>
> empty log message<br>
><br>
> =============== Diff against System-bf.692 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: Preferences class>>loadPreferencesFrom: (in category 'personalization') -----<br>
> + loadPreferencesFrom: aFile<br>
> - loadPreferencesFrom: aFileName<br>
> | stream params dict desktopColor |<br>
> + stream := ReferenceStream on: aFile.<br>
> - stream := ReferenceStream fileNamed: aFileName.<br>
> params := stream next.<br>
> self assert: (params isKindOf: IdentityDictionary).<br>
> params removeKey: #PersonalDictionaryOfPreferences.<br>
> dict := stream next.<br>
> self assert: (dict isKindOf: IdentityDictionary).<br>
> desktopColor := stream next.<br>
> stream close.<br>
> dict keysAndValuesDo:<br>
> [:key :value | (self preferenceAt: key ifAbsent: [nil]) ifNotNil:<br>
> [:pref | pref preferenceValue: value preferenceValue]].<br>
><br>
> params keysAndValuesDo: [ :key :value | self setParameter: key to: value ].<br>
><br>
> Smalltalk isMorphic<br>
> ifTrue: [ World fillStyle: desktopColor ]<br>
> ifFalse: [ self desktopColor: desktopColor. ScheduledControllers updateGray ].<br>
> !<br>
><br>
> Item was changed:<br>
> ----- Method: Preferences class>>restorePreferencesFromDisk (in category 'personalization') -----<br>
> restorePreferencesFromDisk<br>
> + | result |<br>
> + result := (FileList2 modalFileSelectorForSuffixes: #('prefs')) .<br>
> + result ifNil: [^ self].<br>
> + self restorePreferencesFromDisk: result<br>
> +<br>
> - (FileDirectory default fileExists: 'my.prefs')<br>
> - ifTrue: [ Cursor wait showWhile: [<br>
> - [ self loadPreferencesFrom: 'my.prefs' ] on: Error do: [ :ex | self inform: 'there was an error restoring the preferences' ]<br>
> - ] ]<br>
> - ifFalse: [ self inform: 'you haven''t saved your preferences yet!!' ].<br>
> !<br>
><br>
> Item was added:<br>
> + ----- Method: Preferences class>>restorePreferencesFromDisk: (in category 'personalization') -----<br>
> + restorePreferencesFromDisk: aFile<br>
> + Cursor wait<br>
> + showWhile: [[self loadPreferencesFrom: aFile]<br>
> + on: Error<br>
> + do: [:ex | self halt.self inform: 'there was an error restoring the preferences' translated]]!<br>
><br>
> Item was changed:<br>
> ----- Method: Preferences class>>storePreferencesToDisk (in category 'personalization') -----<br>
> storePreferencesToDisk<br>
> + | newName |<br>
> + newName := UIManager default request: 'Please confirm name for save...' initialAnswer: 'myPreferences'.<br>
> + newName isEmpty<br>
> + ifTrue: [^ self].<br>
> + Cursor wait<br>
> + showWhile: [[self storePreferencesIn: newName , '.prefs']<br>
> + on: Error<br>
> + do: [:ex | self inform: 'there was an error storing your preferences to disk. you probably already have stored your preferences' translated]]!<br>
> - Cursor wait showWhile: [<br>
> - [ self storePreferencesIn: 'my.prefs' ] on: Error do: [ :ex | self inform: 'there was an error storing your preferences to disk' ]]!<br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>