<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Feb 1, 2015 at 1:05 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ParagraphEditor is in ST-80, so not part of this package. Speaking of<br>
that, is a corresponding change to ParagraphEditor necessary? Is<br>
ParagraphEditor intended to be purged at some point?<br></blockquote><div><br></div><div>Not necessarily. People use it as a way of reducing footprint. Whether we can afford to keep it going long term is debatable but so far people like David Lewis have done a good job of keeping it working. So by all means fix compare to clipboard therein.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Sun, Feb 1, 2015 at 1:06 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Chris Muller uploaded a new version of Morphic to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/Morphic-cmm.756.mcz" target="_blank">http://source.squeak.org/trunk/Morphic-cmm.756.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: Morphic-cmm.756<br>
> Author: cmm<br>
> Time: 1 February 2015, 1:06:11.045 pm<br>
> UUID: c1553853-472d-45ca-a182-c07497c6f7a9<br>
> Ancestors: Morphic-cmm.755<br>
><br>
> - Present the comparison to clipboard text from the context of paste-modification, since that is what the user is determining whether to do with the clipboard contents.<br>
> - Make the same change to ParagraphEditor, for consistency.<br>
><br>
> =============== Diff against Morphic-cmm.755 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: TextEditor>>compareToClipboard (in category 'menu messages') -----<br>
> compareToClipboard<br>
> + "If any text is selected, present the modifications that would be made to it if the clipboard contents were pasted over it. If no text is selected, present the differences betwen the entire pane's contents and the clipboard text."<br>
> + | subjectText proposedText |<br>
> + subjectText := self selection string ifEmpty: [ paragraph text string ].<br>
> + proposedText := self clipboardText string.<br>
> + subjectText = proposedText ifTrue: [^ self inform: 'Exact match'].<br>
> + (StringHolder new<br>
> + textContents:<br>
> + (TextDiffBuilder<br>
> + buildDisplayPatchFrom: subjectText<br>
> + to: proposedText)) openLabel: 'Differences with Clipboard Text'!<br>
> - "Check to see if whether the receiver's text is the same as the text currently on the clipboard, and inform the user."<br>
> - | s1 s2 |<br>
> - s1 := self clipboardText string.<br>
> - s2 := self selection string.<br>
> - s1 = s2 ifTrue: [^ self inform: 'Exact match'].<br>
> -<br>
> - (StringHolder new textContents:<br>
> - (TextDiffBuilder buildDisplayPatchFrom: s1 to: s2))<br>
> - openLabel: 'Comparison to Clipboard Text'!<br>
><br>
><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">best,<div>Eliot</div></div>
</div></div>