<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-03-27 0:27 GMT+01:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tobias Pape uploaded a new version of Tools to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tools-topa.563.mcz" target="_blank">http://source.squeak.org/trunk/Tools-topa.563.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tools-topa.563<br>
Author: topa<br>
Time: 27 March 2015, 12:27:31.114 am<br>
UUID: 7fb2f85e-8ba3-4ec4-be83-3c9275f7f80b<br>
Ancestors: Tools-topa.562<br>
<br>
Fix menu entry sort to actually match (intended) description<br>
<br>
=============== Diff against Tools-topa.562 ===============<br>
<br>
Item was changed:<br>
----- Method: StringHolder>>menuBuildersFor:in: (in category '*Tools-pluggable menus') -----<br>
menuBuildersFor: someMenus in: aClass<br>
"Find all builders and sort them by<br>
1. Priority (default 500)<br>
2. selector name<br>
3. inheritance<br>
"<br>
^ (self menuPragmasFor: someMenus in: aClass) sorted: [:a :b |<br>
|ma mb pa pb|<br>
ma := a method.<br>
mb := b method.<br>
pa := self methodMenuPriority: ma.<br>
pb := self methodMenuPriority: mb.<br>
+ pa <= pb or: [<br>
- pa < pb or: [<br></blockquote><div><br></div><div>I don't understand this.<br></div><div>pa <= pb = false ==> (pa = pb = false)<br></div><div>so the whole or: block becomes dead code no?<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
pa = pb and: [<br>
ma selector <= mb selector and: [<br>
mb methodClass inheritsFrom: ma methodClass]]]]<br>
!<br>
<br>
<br>
</blockquote></div><br></div></div>