<div dir="ltr">Hi Tobias,<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 7, 2015 at 5:30 AM, Tobias Pape <span dir="ltr"><<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<div><div class="h5"><br>
<br>
On 04.04.2015, at 16:59, Frank Shearar <<a href="mailto:frank.shearar@gmail.com">frank.shearar@gmail.com</a>> wrote:<br>
<br>
> On 3 April 2015 at 16:27, Tobias Pape <<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>> wrote:<br>
>> Hey<br>
>><br>
>> I am watching the CI doing its work as changes and fixes<br>
>> chime in.<br>
>> I noticed that there are still 13 test failing[1] and I'm<br>
>> not sure how all of them should be fixed :)<br>
>> Let's make it green!<br>
><br>
> I am _very very happy_ to see someone other than me harping on about<br>
> tests! Please carry on!<br>
><br>
> This one ought to be easy to fix: it's a small breakage in the<br>
> modularity of the image; some methods need to be recategorised as not<br>
> being System: <a href="http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testSystem/" target="_blank">http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testSystem/</a><br>
><br>
> This one too: <a href="http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testTools/" target="_blank">http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testTools/</a><br>
> (Tools shouldn't depend on _ToolBuilder-Morphic_, even though it would<br>
> be OK to depend on ToolBuilder.)<br>
><br>
> And I love that this one fails -<br>
> <a href="http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testMultilingual/" target="_blank">http://build.squeak.org/job/SqueakTrunk/1207/testReport/Tests.Dependencies/PackageDependencyTest/testMultilingual/</a><br>
> - Multilingual no longer depends on TrueType, and our system just got<br>
> one dependency cleaner.<br>
<br>
</div></div>I did some things :)<br>
<br>
But I need help:<br>
There's a strange thing in the decompiler/compiler:<br>
<br>
<a href="http://build.squeak.org/job/SqueakTrunk/lastCompletedBuild/testReport/Tests.Compiler/DecompilerTests/testDecompilerInClassesBAtoBM/" target="_blank">http://build.squeak.org/job/SqueakTrunk/lastCompletedBuild/testReport/Tests.Compiler/DecompilerTests/testDecompilerInClassesBAtoBM/</a><br>
<br>
Somewhere in Behavior>>#toolIconSelector:,<br>
a sequence of 'push nil. pop' is generated that is decompiled as 'nil.'.<br></blockquote><div><br></div><div>Can you mail the symbolic output that shows the bytecode please? SOmetimes the COmpiler is changed but the system is not recompiled, and hence bytecode can be obsolete. I don't think we should bother to fix the decompiler for these cases. But we should remember to do a recompile all at some stage, either before a release or whenever a change to the compiler is made that would change generated code.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This does not match the source and I don't know whether it's a bug in<br>
the Compiler emitting this or the Decompiler not recognizing the emitted<br>
pattern.<br></blockquote><div><br></div><div>So what happens if you recompile the method? Is the push nil, pop sequence still there?</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best<br>
<span class="HOEnZb"><font color="#888888"> -Tobias<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">best,<div>Eliot</div></div>
</div></div>