<div dir="ltr">This sound good.<div><br></div><div>Karl</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 27, 2015 at 12:34 AM, David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Apr 26, 2015 at 04:43:15PM -0500, Chris Muller wrote:<br>
> This assumes I'm only ever building for the world I'm in. What if I'm<br>
> building MVC widgets to go inside a special window inside my Moprhic<br>
> IDE environment?<br>
><br>
> Maybe we should ask the 'builder' if he's a kind of MorphicToolBuilder<br>
> rather than asking the global Smalltalk?<br>
<br>
</span>Presumably an MVC version of the font chooser tool would use a<br>
PluggableTextView, which AFAICT does not know how to turn off text<br>
wrapping. But implementing StringHolderView>>wrapFlag: as a no-op for<br>
Morphic compatibility would be harmless.<br>
<br>
So could we implement PluggableTextMorph>>wrapFlag: to pass the flag<br>
to its TextMorph for Morphic, and implement wrapFlag: as a no-op in<br>
StringHolderView for MVC? That would eliminate the need for an #isMorphic<br>
test in FontChooserTool>>buildWith:<br>
<br>
Dave<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> On Sun, Apr 26, 2015 at 2:41 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> > Karl Ramberg uploaded a new version of Morphic to project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/Morphic-kfr.934.mcz" target="_blank">http://source.squeak.org/trunk/Morphic-kfr.934.mcz</a><br>
> ><br>
> > ==================== Summary ====================<br>
> ><br>
> > Name: Morphic-kfr.934<br>
> > Author: kfr<br>
> > Time: 26 April 2015, 9:40:34.032 pm<br>
> > UUID: fd9f26f3-4ed1-eb4f-a8ee-0f0270153871<br>
> > Ancestors: Morphic-kfr.933<br>
> ><br>
> > Add a check for morphic environment<br>
> ><br>
> > =============== Diff against Morphic-kfr.933 ===============<br>
> ><br>
> > Item was changed:<br>
> > ----- Method: FontChooserTool>>buildWith: (in category 'toolbuilder') -----<br>
> > buildWith: builder<br>
> > "Create the ui for the browser"<br>
> > "ToolBuilder open: self"<br>
> > | windowSpec |<br>
> > self offerStyleList ifTrue:[<br>
> > windowSpec := self buildWindowWith: builder specs: {<br>
> > (0@0 corner: 0.4@0.4) -> [self buildFontListWith: builder].<br>
> > (0.4@0 corner: 0.8@0.4) -> [self buildStyleListWith: builder].<br>
> > (0.8@0 corner: 1.0@0.4) -> [self buildPointSizeListWith: builder].<br>
> > (0.0@0.4 corner: 1.0@0.88) -> [self buildPreviewPaneWith: builder].<br>
> > (0.0@0.88 corner: 1@1) -> [self buildButtonBarWith: builder].<br>
> > }.<br>
> > ] ifFalse:[<br>
> > windowSpec := self buildWindowWith: builder specs: {<br>
> > (0@0 corner: 0.7@0.4) -> [self buildFontListWith: builder].<br>
> > " (0.4@0 corner: 0.8@0.4) -> [self buildStyleListWith: builder]."<br>
> > (0.7@0 corner: 1.0@0.4) -> [self buildPointSizeListWith: builder].<br>
> > (0.0@0.4 corner: 1.0@0.8) -> [self buildPreviewPaneWith: builder].<br>
> > (0.0@0.8 corner: 1@1) -> [self buildButtonBarWith: builder].<br>
> > }.<br>
> > ].<br>
> > windowSpec extent: self initialExtent.<br>
> > window := builder build: windowSpec.<br>
> > "Yes, that's a hack. But it looks ugly with line breaks."<br>
> > + Smalltalk isMorphic ifTrue:[(builder widgetAt: #preview) textMorph wrapFlag: false].<br>
> > - (builder widgetAt: #preview) textMorph wrapFlag: false.<br>
> > (builder widgetAt: #fontList) scrollSelectionIntoView.<br>
> > ^window!<br>
> ><br>
> ><br>
<br>
</div></div></blockquote></div><br></div>