<div dir="ltr">Hi Chris,<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 6, 2015 at 9:05 AM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Could someone teach me about breakpoints? I've only ever done<br>
"breakpoints" by inserting a old-school send to #halt, I'm not<br>
familiar with these new ways of interrupting execution. How are they<br>
done and what is the advantage over halt?<br></blockquote><div><br></div><div>The "toggle breakpoint on entry" takes care of inserting the break and running the compile, or undoing the break, in one menu selection. So it's faster than using halt. Also, it does not disturb the current change set (it is not considered a change), nor does it create a version of the method nor leave source on the changes file. So it's cleaner. Now that it preserves source I prefer it to halt. Previously it used to install a breakpointed method with decompiled source, which was horrible if one wanted to read comments or had trouble with the formatting.</div><div><br></div><div>WrappedBreakpoint is a step towards a more complete debugging package, but it isn't used yet.</div><div><br></div><div>As a somewhat relevant aside, Terry Raymond of Crafted Smalltalk implemented the Professional Debug Package for VisualWorks which provides conditional breakpoints along with a comprehensive UI. It's powerful and nice to use. While it's relatively easy to roll your own conditional breakpoints above halt, it's nice not to have to think about it to heavily (it's easy to make a mistake and the effects can be terminal :-) ). Perhaps we'll evolve BreakpointManager in that direction. For example, adding a "toggle one-shot breakpoint"would be easy to add; for example inserting breakonce instead of break could cause the breakpointed method to be uninstalled immediately.</div><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Mon, Jul 6, 2015 at 11:01 AM, Tobias Pape <<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>> wrote:<br>
><br>
> On 06.07.2015, at 17:54, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br>
><br>
>> Hi Tobias,<br>
>><br>
>> On Jul 6, 2015, at 8:07 AM, Tobias Pape <<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>> wrote:<br>
>><br>
>>> Hi Eliot<br>
>>> On 06.07.2015, at 15:40, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com">eliot.miranda@gmail.com</a>> wrote:<br>
>>><br>
>>>> Hi Tobias,<br>
>>>><br>
>>>> there /are/ configurations. Two if then :-(.<br>
>>><br>
>>> Sorry, it was just a guess because of the stack trace.<br>
>>><br>
>>> So, I investigated.<br>
>>><br>
>>> update-eem.319.mcm:<br>
>>> (CompiledMethod methodDict includesKay: #hasBreakpoint) "true"<br>
>>><br>
>>> CompiledMethod>>#hasBreakpoint<br>
>>> ^BreakpointManager methodHasBreakpoint: self<br>
>>><br>
>>> update-eem.320.mcm:<br>
>>> (CompiledMethod methodDict includesKey: #hasBreakpoint) "true"<br>
>>><br>
>>> CompiledMethod>>#hasBreakpoint<br>
>>> ^false<br>
>>><br>
>>> update-eem.320.mcm:<br>
>>> (CompiledMethod methodDict includesKey: #hasBreakpoint) "true"<br>
>>><br>
>>> CompiledMethod>>#hasBreakpoint<br>
>>> ^false<br>
>>><br>
>>> Kernel-eem.934<br>
>>><br>
>>> (CompiledMethod methodDict includesKey: #hasBreakpoint) "false"<br>
>>><br>
>>><br>
>>> Ahaa.<br>
>>> System misses to use an actual override and monticello thought the method had gone<br>
>>> when it was saved for Kernel-eem.934.<br>
>>> Soo:<br>
>>> Kernel-topa.935: Reinstall CompiledMethod>>#hasBreakpoint<br>
>>> System-topa.753: Reinstall CompiledMethod>>#hasBreakpoint as an Override<br>
>>> Jenkins seems to be happy:<br>
>>> <a href="http://build.squeak.org/job/SqueakTrunk/1549/console" rel="noreferrer" target="_blank">http://build.squeak.org/job/SqueakTrunk/1549/console</a><br>
>>> <a href="http://build.squeak.org/job/SqueakTrunk/1549/" rel="noreferrer" target="_blank">http://build.squeak.org/job/SqueakTrunk/1549/</a><br>
>>><br>
>>> I hope this fits everyones :)<br>
>>><br>
>>> Best regards<br>
>>> -Tobias<br>
>>><br>
>>><br>
>>> PS: Have you looked at WrappedBreakpoint?<br>
>><br>
>> No. I'll try and take a look. What do you think the issue is?<br>
><br>
> No issue, just an alternative way of doing breakpoints<br>
><br>
>><br>
>>>> Eliot (phone)<br>
>>>><br>
>>>> On Jul 6, 2015, at 3:03 AM, Tobias Pape <<a href="mailto:Das.Linux@gmx.de">Das.Linux@gmx.de</a>> wrote:<br>
>>>><br>
>>>>> Hi,<br>
>>>>><br>
>>>>> we might need a configuration for Eliot's recent #hasBreakpoint changes,<br>
>>>>> the CI (and probably any update process) chokes on this:<br>
>>>>><br>
>>>>> 2015-07-06T11:27:54.732+01:00: Installing Kernel-eem.934<br>
>>>>> vvvvvvvvvvvvvvvvvv MessageNotUnderstood: CompiledMethod>>hasBreakpoint vvvvvvvvvvvvvvvvvv<br>
>>>>> The time is 2015-07-06T11:27:54.848+01:00<br>
>>>>> CompiledMethod(Object)>>doesNotUnderstand: #hasBreakpoint<br>
>>>>> MCMcmUpdater class(ClassDescription)>>logMethodSource:forMethodWithNode:inCategory:withStamp:notifying:<br>
>>>>> MethodAddition>>writeSourceToLog<br>
>>>>> MethodAddition>>createCompiledMethod<br>
>>>>> [] in [] in [] in [] in [] in MCPackageLoader>>basicLoad<br>
>>>>> [] in [] in OrderedCollection(Collection)>>do:displayingProgress:every:<br>
>>>>> OrderedCollection>>do:<br>
>>>>> [] in OrderedCollection(Collection)>>do:displayingProgress:every:<br>
>>>>> [] in [] in MorphicUIManager>>displayProgress:at:from:to:during:<br>
>>>>> BlockClosure>>on:do:<br>
>>>>> [] in MorphicUIManager>>displayProgress:at:from:to:during:<br>
>>>>> BlockClosure>>ensure:<br>
>>>>> MorphicUIManager>>displayProgress:at:from:to:during:<br>
>>>>> ProgressInitiationException>>defaultResumeValue<br>
>>>>> ProgressInitiationException(Exception)>>resume<br>
>>>>> [] in [] in UndefinedObject>>DoIt<br>
>>>>><br>
>>>>> Best regards<br>
>>>>> -Tobias<br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">best,<div>Eliot</div></div>
</div></div>