<div dir="ltr">Hi Max,<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 21, 2015 at 8:57 AM, Max Leske <span dir="ltr"><<a href="mailto:maxleske@gmail.com" target="_blank">maxleske@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi folks<br>
<br>
I’ve been trying to load Fuel into Squeak 5 but can’t because I get errors when loading Traits (they have not instance variables). The reason for this error seems to be that #instSize answers 2 for Traits when it should answer 0.<br>
<br>
The current implementation is:<br>
<br>
^format bitAnd: 16rFFFF<br>
<br>
The comment in the 4.6 version says:<br>
<br>
"<br>
NOTE: This code supports the backward-compatible extension to 8 bits of instSize.<br>
When we revise the image format, it should become...<br>
^ ((format bitShift: -1) bitAnd: 16rFF) - 1<br>
Note also that every other method in this category will require<br>
2 bits more of right shift after the change.<br>
“<br>
<br>
When I use that version in TraitBehaviour>>instSize in Squeak 5 I get 0 as expected and I can load Fuel without problems.<br></blockquote><div><br></div><div>So Spur has a different layout for format than V3. The above implementation (format bitAnd: 16rFFFF) is correct for Spur. In loading classes or traits via Fuel from 4.6 to 5.0 you're going to have to convert the format inst var to reflect its usage in Spur. So we need to be clear here.</div><div><br></div><div>Is the issue that you're trying to load classes and/or traits from a Fuel file written by 4.6 or is it that as part of the Fuel load a new Trait gets created which has a format of 2?</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Max<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>