<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Hi David, Hi All,</div><div><br></div><div> I see a couple of issues with the update map name I can't solve. First, the change made in May to use a default McMcmUpdater instance means that the update map name is cached in the instance and I don't see how changing it in the Preferences browser would either flush the default instance or update the default instance's updateMapName. Second, changing the update map name in the Preferences browser has no effect. This seems to be because there's a conflict between the instance creation message for an McMcmUpdater:</div><div><br></div><div><div>McMcmUpdater class>>updateMapName: baseName</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Answer a new instance with a base update name baseName such as</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>'update' or 'update.oscog' "</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>^ self new updateMapName: baseName</div></div></div><div><br></div><div>and that this is used as the default setter for the preference:</div><div><br></div><div><div>McMcmUpdater class>>updateMapName</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"Name for update map, without version info"</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span><preference: 'Update map name'</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>category: 'updates'</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>description: 'Base name for the update maps'</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>type: #String></div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>^UpdateMapName ifNil: ['update']</div></div><div><br></div><div>So I guess that we could rename the instance creation message to be forUpdateMapName: or simply nuke it. i.e. this</div><div><br></div><div><div>McMcmUpdater class>>default</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"The default instance for system updates. Uses a default update map</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>name that may be set as a preference to enable a specific update stream</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>for a repository."</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>^ self updaters</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>at: self defaultUpdateURL</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>ifAbsentPut: [self updateMapName: self updateMapName]</div></div><div><br></div><div>would become</div><div><br></div><div><div>McMcmUpdater class>>default</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"The default instance for system updates. Uses a default update map</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>name that may be set as a preference to enable a specific update stream</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>for a repository."</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>^ self updaters</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>at: self defaultUpdateURL</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>ifAbsentPut: [self forUpdateMapName: self updateMapName]</div></div><div><br></div><div>or</div><div><br></div><div><div>McMcmUpdater class>>default</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>"The default instance for system updates. Uses a default update map</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>name that may be set as a preference to enable a specific update stream</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>for a repository."</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>^ self updaters</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>at: self defaultUpdateURL</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>ifAbsentPut: [self new updateMapName: self updateMapName]</div></div><div><br></div><div>and updateMapName: would become</div><div><br></div><div>McMcmUpdater class>> updateMapName: aString<br></div><div><br></div><span class="Apple-tab-span" style="white-space:pre"> </span>UpdateMapName := aString</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>