<div dir="ltr">Thanks!<br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-09-15 4:24 GMT+02:00 David T. Lewis <span dir="ltr"><<a href="mailto:lewis@mail.msen.com" target="_blank">lewis@mail.msen.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
On Sun, Sep 13, 2015 at 07:17:51PM -0400, David T. Lewis wrote:<br>
><br>
> On Sun, Sep 13, 2015 at 10:23:42PM +0200, Nicolai Hess wrote:<br>
> ><br>
> > I am about to close some old mantis reports.<br>
> ><br>
> > There are two issues related to the vm and easy to solve ( I think).<br>
> ><br>
> > <a href="http://bugs.squeak.org/view.php?id=7265" rel="noreferrer" target="_blank">http://bugs.squeak.org/view.php?id=7265</a><br>
> ><br>
> > 0007265: Bug in Matrix2x3Plugin okayIntValue:<br>
> > Method<br>
> > okayIntValue: value<br>
> > uses argument to compare with lower bound, m23ResultX for upper bound.<br>
> ><br>
> > okayIntValue: value<br>
> > ^(value >= -1073741824 asFloat and:[m23ResultX <= 1073741823 asFloat])<br>
> ><br>
> > should be:<br>
> > okayIntValue: value<br>
> > ^(value >= -1073741824 asFloat and:[value <= 1073741823 asFloat])<br>
> ><br>
> > I looked at the Matrix2x3Plugin code, and the wrong comparsion<br>
> > is still there.<br>
><br>
> I am quite sure you are right about this, just from looking at the code.<br>
> But I do want to check - the method is from ar 1998, so it has been in all<br>
> the VMs for a very long time. How did you find the problem? Is there a<br>
> test or an example that shows the issue?<br>
><br>
> After fixing the method as you suggest, it will test for integer values<br>
> with bit values in the range 11000000000000000000000000000000 through<br>
> 00111111111111111111111111111111, which presumably maps to a range of<br>
> acceptable values for use in the Matrix2x3Plugin floating point operations.<br>
> So that looks quite reasonable, but I am puzzled that this check has been<br>
> wrong since 1998, so that is why I ask.<br>
><br>
<br>
</div></div>I closed issue 7265. Eliot added your fix to Spur/Cog I did likewise for<br>
VMM trunk (interpreter VM).<br>
<br>
Dave<br>
<br>
</blockquote></div><br></div>