<div dir="ltr">Maybe it would be nice if the filters where off when opening the SqueakMap browser. With filters on it seems to be empty and not functioning. <div><br></div><div>There is always warnings about package not being compatible when you try to load them anyway.</div><div><br></div><div>Karl</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 15, 2015 at 10:04 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">After review and some thought, it has become clear to me that Dave's<br>
change is incorrect. Please take a look at the SqueakMap filters and<br>
consider them from the context of the use-cases -- what users need to<br>
do with SqueakMap, and NOT from the context of a database that needs<br>
to produce generalized "query results" <---- because it doesn't.<br>
<br>
"Published" are the ones which have software to install, while<br>
"Auto-installable" shows only packages that are installable from the<br>
"Install" menu selection within the image. These two filters are<br>
useful together in a restricting fashion, not an inflating one, so<br>
that newbies can see what's ready to go.<br>
<br>
It was then that I also realized that Hannes' combination was not a<br>
use-case either. The use-cases we have are: 1) user wants to install<br>
software or, 2) user wants to see what they have already installed.<br>
Seeing a cumulative list of both installed and uninstalled satisfies<br>
neither use-case.<br>
<br>
Nevertheless you may once again "Clear all filters" (which was broken<br>
by Dave's commit) if you want to see everything.<br>
<br>
I still say SqueakMap catalog can and needs improvement, but we need<br>
to really consider our changes because its clear that Göran put a lot<br>
of thought into the usage of SqueakMap and its role in the community;<br>
so I think we can afford to be a bit more skeptical before thinking<br>
something like that was a bug in the first place and for nine years<br>
running..<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, Sep 15, 2015 at 2:58 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
> Chris Muller uploaded a new version of SMLoader to project The Trunk:<br>
> <a href="http://source.squeak.org/trunk/SMLoader-cmm.85.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/SMLoader-cmm.85.mcz</a><br>
><br>
> ==================== Summary ====================<br>
><br>
> Name: SMLoader-cmm.85<br>
> Author: cmm<br>
> Time: 15 September 2015, 2:58:07.033 pm<br>
> UUID: 21a75b8d-4a1b-49c8-8f82-fbbd74fae96b<br>
> Ancestors: SMLoader-dtl.84<br>
><br>
> Revert dtl.84, because it broke the Catalog filters.<br>
><br>
> =============== Diff against SMLoader-dtl.84 ===============<br>
><br>
> Item was changed:<br>
> ----- Method: SMLoaderPlus>>packageListCalculated (in category 'lists') -----<br>
> packageListCalculated<br>
> "Return a list of the SMPackages that should be visible<br>
> by applying all the filters. Also filter based on the currently<br>
> selected category - if any."<br>
> ^ self packages select: [:p |<br>
> + filters allSatisfy: [:currFilter |<br>
> - filters anySatisfy: [:currFilter |<br>
> currFilter isSymbol<br>
> ifTrue: [(self perform: currFilter) value: p]<br>
> ifFalse: [self package: p filteredByCategory: (map object: currFilter)]]]!<br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>