<div dir="ltr"><div><div>After a first glimpse, I noted these:<br><br>1) GenericGFPoly evaluateAt: does not set the result in the loop...<br></div>2) why using an OrderedCollection for the coefficients ? an Array is faster.<br></div><div> same for exp and log tables of GenericGF<br></div>3) GenericGF>>multiply:scalar: you changed <= size into < size but shouldn't...<br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-12-15 12:30 GMT+01:00 Robert Withers <span dir="ltr"><<a href="mailto:robert.w.withers@gmail.com" target="_blank">robert.w.withers@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi all, sticking with the distribution for discussing Crypto in the
base, I am currently trying to stabilize a port of Reed-Solomon such
that FEC can be added to SecureSession. I am doing this work in
SecureSession. I just posted an update of the GenericGF class, with
the Java implementation attached here. <br>
<br>
I need this critical code reviewed and tested. You need Cryptography
and SecureSession to be included in the catalog. If you can help me
with the former, I could help with the latter, if that suits you.
Please let me know!<br>
<br>
Please load Cryptography(-Pharo) and SecureSession.23 for review. <br>
<blockquote>"ported & refactored GenericGF from the java code.
This includes reindexing from 0 to 1. Having no tests, hopefully
someone can give a review of this specific class. Where some tests
to be developed at this scope, that would be stellar."<br>
</blockquote>
<br>
I appreciate.<span class="HOEnZb"><font color="#888888"><br>
<div>-- <br>
<div align="center">. .. .. ^,^ best, robert
</div>
</div>
</font></span></div>
<br><br>
<br></blockquote></div><br></div>