<div dir="ltr"><div><div><div>Since GF is all about algebra and arithmetic it should be possible to write tests and check some invariants...<br></div>For example, this works with SecureSession-rww.70:<br><br> | gf |<br> GenericGF xxinitialize.<br> gf := GenericGF RS_256_A.<br> 1 to: gf size - 1 do: [:a | <br> self assert: (gf multiply: a scalar: (gf inverse: a)) = 1]<br><br></div>One could test polynom product vs division for example, for some monomials...<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-12-21 1:19 GMT+01:00 Robert Withers <span dir="ltr"><<a href="mailto:robert.w.withers@gmail.com" target="_blank">robert.w.withers@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hi Nicolas, <br>
<br>
I tried the fixes you suggested (1 and 3) and it still isn't
working. I published tothe repository with these changes, though the
pipeline is broken as I rewire my skull (intro frames). This will
take several days to complete, I think, although progress is being
made. Then I will be able to turn my full attention back to RS and
Arrays for starters. Please pardon the delay, but I think frames
will bring an advantage, perhaps not performance but design and
flexibility.<br>
<br>
Many thanks for taking a close look at RS,<br>
robert<div><div class="h5"><br>
<br>
<div>On 12/20/2015 12:18 PM, Nicolas Cellier
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>After a first glimpse, I noted these:<br>
<br>
1) GenericGFPoly evaluateAt: does not set the result in the
loop...<br>
</div>
2) why using an OrderedCollection for the coefficients ? an
Array is faster.<br>
</div>
<div> same for exp and log tables of GenericGF<br>
</div>
3) GenericGF>>multiply:scalar: you changed <= size into
< size but shouldn't...<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2015-12-15 12:30 GMT+01:00 Robert
Withers <span dir="ltr"><<a href="mailto:robert.w.withers@gmail.com" target="_blank">robert.w.withers@gmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Hi all, sticking with
the distribution for discussing Crypto in the base, I am
currently trying to stabilize a port of Reed-Solomon such
that FEC can be added to SecureSession. I am doing this
work in SecureSession. I just posted an update of the
GenericGF class, with the Java implementation attached
here. <br>
<br>
I need this critical code reviewed and tested. You need
Cryptography and SecureSession to be included in the
catalog. If you can help me with the former, I could help
with the latter, if that suits you. Please let me know!<br>
<br>
Please load Cryptography(-Pharo) and SecureSession.23 for
review. <br>
<blockquote>"ported & refactored GenericGF from the
java code. This includes reindexing from 0 to 1. Having
no tests, hopefully someone can give a review of this
specific class. Where some tests to be developed at this
scope, that would be stellar."<br>
</blockquote>
<br>
I appreciate.<span><font color="#888888"><br>
<div>-- <br>
<div align="center">. .. .. ^,^ best, robert </div>
</div>
</font></span></div>
<br>
<br>
<br>
</blockquote>
</div>
<br>
</div>
<br>
<fieldset></fieldset>
<br>
<pre></pre>
</blockquote>
<br>
</div></div><span class="HOEnZb"><font color="#888888"><div>-- <br>
<div align="left">. .. .. ^,^ robert
</div>
</div>
</font></span></div>
<br><br>
<br></blockquote></div><br></div>