<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-04-08 20:26 GMT+02:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-mt.842.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk/Morphic-mt.842.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-mt.842<br>
Author: mt<br>
Time: 8 April 2015, 8:26:35.712 pm<br>
UUID: 69b4e9ef-0563-9748-a5bf-fe69528f37b8<br>
Ancestors: Morphic-mt.841<br>
<br>
Made Slider more pluggable and thus removed PluggableSliderMorph from the system. The code that was not moved upwards into Slider was moved downwards into its sole subclass: BracketSliderMorph.<br>
<br>
It was verified that the "new color picker morph", which is the sole user of that BracketSliderMorph, stays functional.<br>
<br>
Why? The Slider should support custom min/max values whenever the default (floats with 0.0 to 1.0) is not appropriate. Truncation is supported, too. Everything was already present in the (removed) PluggableSliderMorph, but we need that behavior in ScrollBar.<br>
<br>
Note: There is still the SimpleSliderMorph, which duplicates some behavior of Slider but is a base class of slider. E-Toys uses it. We may want to remove that duplicated code later.<br>
<br>
=============== Diff against Morphic-mt.841 ===============<br>
<br>
Item was changed:<br>
+ Slider subclass: #BracketSliderMorph<br>
+ instanceVariableNames: 'getEnabledSelector enabled'<br>
- PluggableSliderMorph subclass: #BracketSliderMorph<br>
- instanceVariableNames: ''<br>
classVariableNames: ''<br>
poolDictionaries: ''<br>
category: 'Morphic-Widgets'!<br>
<br>
!BracketSliderMorph commentStamp: 'gvc 5/18/2007 13:39' prior: 0!<br>
Abstract superclass for morphs that are used to select a component (R, G, B or A) of a colour.!<br>
<br>
Item was added:<br>
+ ----- Method: BracketSliderMorph>>adoptPaneColor: (in category 'accessing - ui') -----<br>
+ adoptPaneColor: paneColor<br>
+ "Pass on to the border too."<br>
+ super adoptPaneColor: paneColor.<br>
+ paneColor ifNil: [ ^ self ].<br>
+ self<br>
+ fillStyle: self fillStyleToUse ;<br>
+ borderStyle:<br>
+ (BorderStyle inset<br>
+ width: 1 ;<br>
+ baseColor: self color twiceDarker) ;<br>
+ sliderColor:<br>
+ (self enabled<br>
+ ifTrue: [ paneColor twiceDarker ]<br>
+ ifFalse: [ self paneColor twiceDarker paler ])!<br>
<br>
Item was added:<br>
+ ----- Method: BracketSliderMorph>>borderStyleToUse (in category 'accessing - ui') -----<br>
+ borderStyleToUse<br>
+ "Answer the borderStyle that should be used for the receiver."<br>
+<br>
+ ^self enabled<br>
+ ifTrue: [self theme sliderNormalBorderStyleFor: self]<br>
+ ifFalse: [self theme sliderDisabledBorderStyleFor: self]!<br>
<br></blockquote><div><br></div><div>Hi Marcel,<br></div><div>theme?<br></div><div>There's no theme (yet) in Squeak...<br></div><div>Is it something that leaked from some other framework?<br></div></div><br></div></div>