<div dir="ltr"><div>Thanks, Chris and Bert.</div>I think I found the reason I had problems.<div>If you change instance variables but not any methods you get the methodListMenu: from MCOperationsBrowser but not the one from MCCodeTool.</div><div><br></div><div>There is only 'browse origins' in the MCOperationsBrowser>>methodListMenu:</div><div><br></div><div>So the fix must be to fix MCCodeTool>>methodListMenu: to at least give option to 'browse full' so one can get to the class.</div><div><br></div><div>Best,</div><div>Karl</div><div><div><br></div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 24, 2016 at 9:27 PM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi Karl, mcModel is for the history function, the code shouldn't be<br>
getting there for a regular browse class. Are you sure you didn't<br>
select "browse mc history" or "browse mc origin"?<br>
<br>
PS -- I still plan to try to fix the mc history function again..<br>
<div><div><br>
On Tue, May 24, 2016 at 12:31 PM, karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
> Ok, it only fails if MCMethodDefinition>>mcModel is nil in<br>
> MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference<br>
><br>
> Once you have the MCMethodDefinition>>mcModel installed it will work the<br>
> next time, so my fix is still necessary<br>
><br>
><br>
><br>
> Best,<br>
> Karl<br>
><br>
> On Tue, May 24, 2016 at 6:41 PM, karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
>><br>
>> Hm, weird.<br>
>> I removed the fix I did and now it works...<br>
>><br>
>> Not sure what was going on<br>
>><br>
>> Best,<br>
>> Karl<br>
>><br>
>> On Tue, May 24, 2016 at 6:33 PM, Bert Freudenberg <<a href="mailto:bert@freudenbergs.de" target="_blank">bert@freudenbergs.de</a>><br>
>> wrote:<br>
>>><br>
>>> Which menu item are you trying? You wrote “can open a browser from the<br>
>>> context menu” and for me both cmd-b and the context menu work for opening a<br>
>>> System Browser.<br>
>>><br>
>>> - Bert -<br>
>>><br>
>>><br>
>>> On 24.05.2016, at 18:27, karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
>>><br>
>>><br>
>>> I know packageInfo is not the same as workingCopy but I'm not sure how to<br>
>>> reference it from the merge browser.<br>
>>><br>
>>> How can this be working in your image ? packageInfo is not implemented<br>
>>> for MCMethodDefinition...<br>
>>><br>
>>><br>
>>> It's called from<br>
>>> MCWorkingCopyBrowser>>mcModelFor: aClassOrMethodReference<br>
>>> ^ aClassOrMethodReference mcModel ifNil:<br>
>>> [ | pkgName rep | (UIManager confirm: 'Okay to add historical repository<br>
>>> ' , (rep := MCHttpRepository trunkBackup) description , ' to ' , (pkgName :=<br>
>>> aClassOrMethodReference packageInfo packageName) , '?') ifTrue:<br>
>>> [ (MCWorkingCopy forPackageNamed: pkgName) repositoryGroup addRepository:<br>
>>> rep.<br>
>>> aClassOrMethodReference mcModel ] ]<br>
>>><br>
>>> Best,<br>
>>> Karl<br>
>>><br>
>>> On Tue, May 24, 2016 at 5:56 PM, Bert Freudenberg <<a href="mailto:bert@freudenbergs.de" target="_blank">bert@freudenbergs.de</a>><br>
>>> wrote:<br>
>>>><br>
>>>> On 24.05.2016, at 17:17, karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
>>>> ><br>
>>>> > I'm pretty sure this is a proper fix so the MCMergeBrowser can open a<br>
>>>> > browser from the context menu:<br>
>>>><br>
>>>> This appears to work fine for me even without that change.<br>
>>>><br>
>>>> > MCMethodDefinition>>packageInfo<br>
>>>> ><br>
>>>> > ^ self workingCopy! !<br>
>>>><br>
>>>> … and a WorkingCopy most definitely is not the same as a PackageInfo ;)<br>
>>>><br>
>>>> - Bert -<br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>><br>
><br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div></div></div></div>