<div dir="ltr"><div>Fortunately, the server doesn't diffsWithPrettyPrint ;)<br></div>That's definitely one Preferences to be set to false by default IMO.<br></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-16 18:01 GMT+02:00 Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Aug 15, 2016 at 4:05 PM, Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@caesar.elte.hu" target="_blank">leves@caesar.elte.hu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Mon, 15 Aug 2016, <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Patrick Rein uploaded a new version of Tests to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Tests-pre.349.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk<wbr>/Tests-pre.349.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Tests-pre.349<br>
Author: pre<br>
Time: 15 August 2016, 11:23:47.344656 pm<br>
UUID: ab567e83-59da-9049-af1a-aa3c78<wbr>112c85<br>
Ancestors: Tests-pre.348<br>
<br>
Updates decompiler expected failures to the new state of the source code.<br>
<br>
=============== Diff against Tests-pre.348 ===============<br>
<br>
Item was changed:<br>
----- Method: DecompilerTests>>decompilerFai<wbr>lures (in category 'utilities') -----<br>
decompilerFailures<br>
"Here is the list of failures: either a syntax error, a hard error or some failure to decompile correctly.<br>
Collected via<br>
DecompilerTestFailuresCollecto<wbr>r new computeFailures."<br>
<br>
"class name, selector, error class name or nil"<br>
+ ^ #(#(#Behavior #toolIconSelector: #TestFailure) #(#BrowserCommentTextMorph #showPane #SyntaxErrorNotification) #(#ClassDescription #replaceSilently:to: #SyntaxErrorNotification) #(#CodeHolder #getSelectorAndSendQuery:to:wi<wbr>th: #SyntaxErrorNotification) #(#Date #printOn: #TestFailure) #(#DecompilerTests #testDecompileUnreachableParam<wbr>eter #Error) #(#FontImporterTool #fontFromFamily: #SyntaxErrorNotification) #(#HttpUrl #checkAuthorization:retry: #TestFailure) #(#LargeNegativeIntegerTest #testReplaceFromToWithStarting<wbr>At #SyntaxErrorNotification) #(#LargePositiveIntegerTest #testReplaceFromToWithStarting<wbr>At #SyntaxErrorNotification) #(#MailComposition #breakLinesInMessage: #SyntaxErrorNotification) #(#MCConfigurationBrowser #post #SyntaxErrorNotification) #(#MVCToolBuilder #setLayout:in: #SyntaxErrorNotification) #(#ParagraphEditor #inOutdent:delta: #SyntaxErrorNotification) #(#PNGReadWriter #copyPixelsGray: #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNilIfNotNil #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNotNil #SyntaxErrorNotification) #(#ProtoObjectTest #testIfNotNilIfNil #SyntaxErrorNotification) #(#RxsCharSet #enumerablePartPredicateIgnori<wbr>ngCase: #SyntaxErrorNotification) #(#ScaledDecimalTest #testConvertFromFraction #SyntaxErrorNotification) #(#SHMCClassDefinition #withAllSuperclassesDo: #SyntaxErrorNotification) #(#StandardScriptingSystem #holderWithAlphabet #SyntaxErrorNotification) #(#SyntaxMorph #mouseEnterDragging: #SyntaxErrorNotification) #(#SystemWindow #convertAlignment #SyntaxErrorNotification) #(#TextEditor #inOutdent:delta: #SyntaxErrorNotification) #(#TextURL #actOnClickFor: #TestFailure) #(#WeakSet #scanForLoadedSymbol: #TestFailure))!<br>
</blockquote>
<br></span>
Please keep the indentation.</blockquote><div><br></div></span><div>+1. It's unreadable without :-(</div><span class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><font color="#888888"><br>
<br>
Levente</font></span><div><div><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- ^#( (Behavior toolIconSelector: TestFailure)<br>
- (BrowserCommentTextMorph showPane SyntaxErrorNotification)<br>
- (ClassDescription replaceSilently:to: SyntaxErrorNotification)<br>
- (CodeHolder getSelectorAndSendQuery:to:wit<wbr>h: SyntaxErrorNotification)<br>
- (Date printOn: TestFailure)<br>
- (DecompilerTests testDecompileUnreachableParame<wbr>ter Error)<br>
- (FontImporterTool fontFromFamily: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (HttpUrl checkAuthorization:retry: TestFailure)<br>
- (LargeNegativeIntegerTest testReplaceFromToWithStartingA<wbr>t SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (LargePositiveIntegerTest testReplaceFromToWithStartingA<wbr>t SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (MailComposition breakLinesInMessage: SyntaxErrorNotification)<br>
- (MCConfigurationBrowser post SyntaxErrorNotification)<br>
- (MVCToolBuilder setLayout:in: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (ParagraphEditor inOutdent:delta: SyntaxErrorNotification)<br>
- (PNGReadWriter copyPixelsGray: SyntaxErrorNotification)<br>
- (ScaledDecimalTest testConvertFromFraction SyntaxErrorNotification) "local/non-local temps"<br>
- (SHMCClassDefinition withAllSuperclassesDo: SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (StandardScriptingSystem holderWithAlphabet SyntaxErrorNotification) "same-name block-local temps in optimized blocks"<br>
- (SystemWindow convertAlignment SyntaxErrorNotification)<br>
- (TextEditor inOutdent:delta: SyntaxErrorNotification)<br>
- (TextURL actOnClickFor: TestFailure)<br>
- (TTContourConstruction segmentsDo: SyntaxErrorNotification) "Worth fixing; these two are mistaken conversion from a whileTrue: to a to:do: but the index is used outside the whileTrue:"<br>
- (TTFontReader processHorizontalMetricsTable:<wbr>length: SyntaxErrorNotification))!<br>
<br>
<br>
</blockquote>
</div></div><br><br>
<br></blockquote></span></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</font></span></div></div>
<br><br>
<br></blockquote></div><br></div>