<div dir="ltr"><br><div class="GmSign">On Wed, Aug 17, 2016 at 7:23 PM H. Hirzel <<a href="mailto:hannes.hirzel@gmail.com">hannes.hirzel@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Your suggestion, Fabio, to change the test makes sense to me.<br>
<br>
May I ask you to create a new version on <a href="http://www.squeaksource.com/JSON" rel="noreferrer" target="_blank">http://www.squeaksource.com/JSON</a><br>
and to create a SqueakMap entry for 5.1 which loads that new version?<br>
<br>
--Hannes<br></blockquote><div><br></div><div>I've pushed a new version:</div><div><div><br></div><div>Name: JSON-FabN.38</div><div>Author: FabN</div><div>Time: 17 August 2016, 7:32:28.37 pm</div><div>UUID: 9b27fd7e-4754-436d-b6f5-2348b49f5b63</div><div>Ancestors: JSON-tonyg.37</div></div><div><br></div><div>Unfortunately, I don't have permissions to update the SqueakMap entry. Maybe Tony can take care of this?</div><div><br></div><div>Best,</div><div>Fabio</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 8/17/16, Fabio Niephaus <<a href="mailto:lists@fniephaus.com" target="_blank">lists@fniephaus.com</a>> wrote:<br>
> --<br>
><br>
> On Wed, Aug 17, 2016 at 6:54 PM H. Hirzel <<a href="mailto:hannes.hirzel@gmail.com" target="_blank">hannes.hirzel@gmail.com</a>> wrote:<br>
><br>
>> testing JSON (Squeak 5.1beta-16510)<br>
>><br>
>> MCHttpRepository<br>
>> location: '<a href="http://www.squeaksource.com/JSON" rel="noreferrer" target="_blank">http://www.squeaksource.com/JSON</a>'<br>
>> user: ''<br>
>> password: ''<br>
>><br>
>> Version:<br>
>><br>
>> Name: JSON-tonyg.37<br>
>> Author: tonyg<br>
>> Time: 29 April 2016, 11:47:17.129 am<br>
>> UUID: 63e50a8f-d436-4128-952c-3c0c8c12e120<br>
>><br>
>><br>
>> 16 out of 17 tests pass, 1 failure in<br>
>><br>
>> testStreaming<br>
>> | j |<br>
>> j := Json new stream: 'truefalsetrue[]{}1.234<br>
>> 5.678"A""B"nullnull'<br>
>> readStream.<br>
>> self assert: j readAny equals: true.<br>
>> self assert: j readAny equals: false.<br>
>> self assert: j readAny equals: true.<br>
>> self assert: j readAny equals: #().<br>
>> self assert: j readAny equals: Dictionary new. "<<<<<<<<br>
>> FAILURE HERE "<br>
>><br>
><br>
> I'm not sure if it's a good idea to test if this equals a new dictionary<br>
> here.<br>
> Changing the line like this makes the test pass:<br>
><br>
> self assert: j readAny isDictionary.<br>
><br>
> `j readAny` returns a JsonObject which directly inherits from Dictionary.<br>
><br>
> Best,<br>
> Fabio<br>
><br>
><br>
><br>
>> self assert: j readAny equals: 1.234.<br>
>> self assert: j readAny equals: 5.678.<br>
>> self assert: j readAny equals: 'A'.<br>
>> self assert: j readAny equals: 'B'.<br>
>> self assert: j readAny equals: nil.<br>
>> self assert: j readAny equals: nil.<br>
>><br>
>> --Hannes<br>
>><br>
>><br>
><br>
<br>
</blockquote></div></div>