<div dir="ltr">Hi Max,<br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 22, 2016 at 11:42 AM, Max Leske <span dir="ltr"><<a href="mailto:maxleske@gmail.com" target="_blank">maxleske@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br><div style="word-wrap:break-word"><br><div><blockquote type="cite"><div>On 22 Sep 2016, at 20:28, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:</div><br><div><div dir="ltr">Hi Bert, Hi All,<div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 15, 2016 at 2:55 PM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:</div><div class="gmail_quote">[snip]<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href="http://lists.squeakfoundation.org/pipermail/packages/2016-September/068930.html" rel="noreferrer" target="_blank">http://lists.squeakfoundation.<wbr>org/pipermail/packages/2016-Se<wbr>ptember/068930.html</a><br>
<br>
Name: System-bf.916<br>
Ancestors: System-bf.915<br>
<br>
Replace VM-level ImageSegment loading with a Smalltalk implementation for old (interpreter-era) projects.<br>
<br>
Also removes support for writing segments.<br>
<br>
This overrides the Spur support introduced in System-eem.758.<br></blockquote><div><br></div><div> So one question is should we delete VM support for ImageSegment from the Spur VM? There's at least 1.5k of generated source for the Spur ImageSegment load and save support, some 2% of the interpreter/primitives source code. That's a lot, and the code is complex and ugly. If it never really worked before IMO we should nuke it asap. If it worked in some fashion perhaps we can schedule its demise for the 6.0 release's VM.</div><div><br></div><div>What do others think?</div></div></div></div></div></blockquote><div><br></div><div>As long as you don’t remove it from the Cog VM’s until I no longer need it I’m fine with that.</div></div></div></blockquote><div><br></div><div>And when would that be? Do you mean that you use it in ways not covered by Bert's modifications (which render the VM support superfluous), or do you mean that you use ImageSegment as a naive consumer and are happy just so long as it works?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div>Max</div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div></div><div data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>
</div></blockquote></div><br></div><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>