<div dir="ltr">OK :-)<div>Some of the layout stuff is really painful to debug</div><div><br></div><div>Best,</div><div>Karl</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 27, 2016 at 11:04 PM, Nicolas Cellier <span dir="ltr"><<a href="mailto:nicolas.cellier.aka.nice@gmail.com" target="_blank">nicolas.cellier.aka.nice@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi Karl,<br>Hack sounds like a good name to me.<br>You can't imagine what a nest of stateful twisted tricky code modified during 30 years I had to patiently untangle...<br>But it's very hard to remember all the details 3 years after...<br>Fortunately, we have an electronic memory to assist us:<br>If I dig thru the [The Trunk] commits threads in the mailing list it seems that on 2 October 2013:<br>- the hack was already named "hack" before Graphics-nice.243.mcz</div><div>- it was in generic code (for both Morphic/ST80) but dedicated to ST80 only<br></div><div>- so I ported it back to a ST80 specific scanner in ST80-nice.152.mcz<br><br>So, despite my initials and my opinion, the name "hack" here is not my own production, just a copy/paste ;)<br></div><div>Now that trunk MC server also has a longer memory, you can see the text already present in CharacterBlockcanner>>crossedX version ar 12/15/2001.<br></div><div>And I would not be much surprised that most code in this area comes from Xerox era, and Dan Ingalls himself.<br></div><div><br></div></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2016-10-27 11:04 GMT+02:00 karl ramberg <span dir="ltr"><<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Should the comment be changed here? Or is it still a hack ?<div><br></div><div>Best,</div><div>Karl</div></div><div class="m_-4671004743217339611HOEnZb"><div class="m_-4671004743217339611h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 27, 2016 at 2:43 AM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nicolas Cellier uploaded a new version of ST80 to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/ST80-nice.220.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk<wbr>/ST80-nice.220.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: ST80-nice.220<br>
Author: nice<br>
Time: 27 October 2016, 2:43:25.251747 am<br>
UUID: e617501e-764e-4c9c-8c0c-a2a559<wbr>e84940<br>
Ancestors: ST80-tfel.219<br>
<br>
Remove an old Transcript show: remnant from horrorful text selection debug session.<br>
<br>
=============== Diff against ST80-tfel.219 ===============<br>
<br>
Item was changed:<br>
----- Method: CharacterBlockScannerForMVC>>c<wbr>rossedX (in category 'stop conditions') -----<br>
crossedX<br>
characterIndex == nil ifFalse: [<br>
"If the last character of the last line is a space,<br>
and it crosses the right margin, then locating<br>
the character block after it is impossible without this hack."<br>
+ characterIndex > text size ifTrue: [<br>
- characterIndex > text size ifTrue: [Transcript cr; show:'here'.<br>
lastIndex := characterIndex.<br>
characterPoint := (nextLeftMargin ifNil: [leftMargin]) @ (destY + line lineHeight).<br>
^true]].<br>
^super crossedX!<br>
<br>
<br>
</blockquote></div><br></div>
</div></div><br><br>
<br></blockquote></div><br></div>
</div></div><br><br>
<br></blockquote></div><br></div>