<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 21, 2017 at 11:03 AM, Levente Uzonyi <span dir="ltr"><<a href="mailto:leves@caesar.elte.hu" target="_blank">leves@caesar.elte.hu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Eliot,<br>
<br>
Anyway, I reverted the method to return the raw array, and introduced another one to return just the names.<br>
The old implementation could have caused some head-scrathing, because it just returned a class variable which was not referenced from any other place, so it was never updated.</blockquote><div><br></div><div>Hmmm, now I have to decide if I should revert ;-)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><br>
<br>
Levente</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Tue, 21 Mar 2017, Eliot Miranda wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Levente,<br>
On Tue, Mar 21, 2017 at 9:46 AM, Eliot Miranda <<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>> wrote:<br>
Hi Levente,<br>
please revert the change that eliminates the argument counts from the specialSelectors array ASAP. The VM uses these!! This is causing untold damage in the VM as we speak (for example, it is<br>
related to Hernan's crash). The VM *must* be able to determine the argument count for a special selector it does not inline.<br>
<br>
<br>
Ah, OK. It's not creating damage in the VM, but it is creating damage in the simulator. Forgive me :-). I overreacted.<br>
<br>
<br>
On Sun, Mar 19, 2017 at 4:35 PM, <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br>
Levente Uzonyi uploaded a new version of System to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/System-ul.937.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk<wbr>/System-ul.937.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: System-ul.937<br>
Author: ul<br>
Time: 20 March 2017, 12:35:03.813931 am<br>
UUID: 01691bb8-181f-4795-83ce-201300<wbr>31a81d<br>
Ancestors: System-ul.936<br>
<br>
Fixed SmalltalkImage >> #specialSelectors. SystemTracer doesn't use it any more, but it's being used by tests, which expect it to return only the selectors without their argument<br>
count.<br>
<br>
=============== Diff against System-ul.936 ===============<br>
<br>
Item was changed:<br>
----- Method: SmalltalkImage>>specialSelecto<wbr>rs (in category 'special objects') -----<br>
specialSelectors<br>
+<br>
+ | arrayOfPairs |<br>
+ arrayOfPairs := self specialObjectsArray at: 24.<br>
+ ^Array new: arrayOfPairs size // 2 streamContents: [ :stream |<br>
+ arrayOfPairs pairsDo: [ :selector :numArgs |<br>
+ stream nextPut: selector ] ]<br>
+ !<br>
- "Used by SystemTracer only."<br>
-<br>
- ^SpecialSelectors!<br>
<br>
<br>
<br>
<br>
<br>
--<br>
_,,,^..^,,,_<br>
best, Eliot<br>
<br>
<br>
<br>
<br>
--<br>
_,,,^..^,,,_<br>
best, Eliot<br>
<br>
</blockquote>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>