<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Regarding the headerFlagForEncoder: method: I only wanted to make the </p>
<p>code easier to understand. I have no experience with the CompiledCode </p>
<p>and Encoder classes and did not want to break anything there.<br>
</p>
<p><br>
</p>
<p>Regarding the two commits: I should have ignored the change... I have now<br>
</p>
<p>moved the commit in the Inbox to the Treated Inbox. The change is still<br>
</p>
<p>open for discussion though :)<br>
</p>
<p><br>
</p>
<div style="color: rgb(33, 33, 33);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> on behalf of Nicolas Cellier <nicolas.cellier.aka.nice@gmail.com><br>
<b>Sent:</b> Friday, May 19, 2017 14:32<br>
<b>To:</b> The general-purpose Squeak developers list<br>
<b>Subject:</b> Re: [squeak-dev] The Trunk: Kernel-pre.1105.mcz</font>
<div> </div>
</div>
<div>
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2017-05-19 14:22 GMT+02:00 <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Patrick Rein uploaded a new version of Kernel to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Kernel-pre.1105.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/<wbr>trunk/Kernel-pre.1105.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Kernel-pre.1105<br>
Author: pre<br>
Time: 19 May 2017, 2:22:29.00196 pm<br>
UUID: 7e22498c-7586-584c-a2a9-<wbr>81331c572590<br>
Ancestors: Kernel-pre.1104<br>
<br>
Removes a redundancy in CompiledCode.<br>
<br>
=============== Diff against Kernel-nice.1103 ===============<br>
<br>
Item was changed:<br>
----- Method: CompiledCode class>>headerFlagForEncoder: (in category 'method encoding') -----<br>
headerFlagForEncoder: anEncoder<br>
- anEncoder class == PrimaryBytecodeSetEncoderClass ifTrue:<br>
- [^0].<br>
- anEncoder class == SecondaryBytecodeSetEncoderCla<wbr>ss ifTrue:<br>
- [^SmallInteger minVal].<br>
"This allows subclasses for compiler variants such as the ScriptEncoder in EToys<br>
to continue to function."<br>
+ (anEncoder isKindOf: PrimaryBytecodeSetEncoderClass<wbr>) ifTrue:<br>
- (anEncoder class inheritsFrom: PrimaryBytecodeSetEncoderClass<wbr>) ifTrue:<br>
[^0].<br>
+ (anEncoder isKindOf: SecondaryBytecodeSetEncoderCla<wbr>ss) ifTrue:<br>
- (anEncoder class inheritsFrom: SecondaryBytecodeSetEncoderCla<wbr>ss) ifTrue:<br>
[^SmallInteger minVal].<br>
self error: 'The encoder is not one of the two installed bytecode sets'!<br>
<br>
</blockquote>
<div>Then why not send a message back to anEncoder?<br>
</div>
<div>Way more efficient than testing classes sequentially and recursively...<br>
</div>
<div> <br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Item was added:<br>
+ ----- Method: Number>>** (in category 'mathematical functions') -----<br>
+ ** aNumber<br>
+<br>
+ ^ self raisedTo: aNumber!<br>
<br>
</blockquote>
<div>Above change can't both be waiting in inbox and be commited to trunk <br>
</div>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>