<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)">I dimly remember that. Didn't make sense then, doesn't now. Can we just fix it? Existing code that avoids comparing these versions, or doesn't use ".0" should not break.</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)"><br></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)">- Bert -</span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)"><br></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:#000000"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)">On Thu, Sep 21, 2017 at 2:57 PM, Marcel Taeumel </span><span dir="ltr" style="font-family:arial,sans-serif;color:rgb(34,34,34)"><<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>></span><span style="font-family:arial,sans-serif;color:rgb(34,34,34)"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id="m_5038442811765340140__MailbirdStyleContent" style="font-size:12pt;font-family:calibri;color:#000000">
Here is a discussion about this topic from 2008:<div><a href="http://forum.world.st/squeak-dev-1-0-not-a-valid-VersionNumber-td74872.html" target="_blank">http://forum.world.st/squeak-<wbr>dev-1-0-not-a-valid-<wbr>VersionNumber-td74872.html</a></div><div><br></div><div>It includes an explanation from Stephen Pair, who wrote the code:</div><div><a href="http://forum.world.st/squeak-dev-1-0-not-a-valid-VersionNumber-tp74872p74875.html" target="_blank">http://forum.world.st/squeak-<wbr>dev-1-0-not-a-valid-<wbr>VersionNumber-tp74872p74875.<wbr>html</a></div><div><br></div><div><span style="font-size:12pt;line-height:1.5">Best,</span></div><div>Marcel</div><div><div class="h5"><div class="m_5038442811765340140mb_sig"></div>
<blockquote class="m_5038442811765340140history_container" type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:#aaaaaa;margin-top:10px">Am 21.09.2017 14:38:21 schrieb Bert Freudenberg <<a href="mailto:bert@freudenbergs.de" target="_blank">bert@freudenbergs.de</a>>:</p>
<div dir="ltr"><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0)">That sounds nonsensical. 4.1 should be larger than 3.1, and smaller than 4.1.0. Direct comparison is strictly for listing versions in ascending order, and as Jakob wrote, you need a more complex scheme for other purposes.</div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0)"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0)">- Bert -</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 21, 2017 at 10:47 AM, Marcel Taeumel <span dir="ltr"><<a href="mailto:marcel.taeumel@hpi.de" target="_blank">marcel.taeumel@hpi.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;min-width:500px"><div><div id="m_5038442811765340140m_767816493456297640__MailbirdStyleContent" style="font-size:12pt;font-family:calibri;color:#000000">
If you cannot compare two versions, an error will be raised.<div><br></div><div>Best,</div><div>Marcel</div><div><div class="m_5038442811765340140h5"><div class="m_5038442811765340140m_767816493456297640mb_sig"></div><blockquote class="m_5038442811765340140m_767816493456297640history_container" type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:#aaaaaa;margin-top:10px">Am 21.09.2017 10:26:34 schrieb Jakob Reschke <<a href="mailto:jakob.reschke@student.hpi.de" target="_blank">jakob.reschke@student.hpi.de</a>><wbr>:</p>
<div dir="ltr"><div dir="auto"><div>What is the current behavior if two branched version numbers are compared? true, false, error?</div><div dir="auto"><br></div><div dir="auto">I would say they are not comparable anyway. What do you want to know? "Can I upgrade to get an increment?" "Can I upgrade without breaking some API?" "Which is newer?" All of these cannot be answered without additional information about the versioning scheme (e.g., in SemVer you could answer the first two queries, but not the third without an additional timestamp). And these queries should have their own messages instead of a general-purpose comparison.</div><div dir="auto"><br></div><div dir="auto">Kind regards,</div><div dir="auto">Jakob</div><div dir="auto"><br><div class="gmail_extra" dir="auto"><br><div class="gmail_quote">Am 21.09.2017 08:44 schrieb "Taeumel, Marcel" <<a href="mailto:Marcel.Taeumel@hpi.de" target="_blank">Marcel.Taeumel@hpi.de</a>>:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;min-width:500px">
<div>
<div id="m_5038442811765340140m_767816493456297640m_4569841657242251591m_2551634508952807801m_6604156934940700848__MailbirdStyleContent" style="font-size:12pt;font-family:calibri;color:#000000">
Hi Tobias,
<div><br>
</div>
<div>I see several issues with the current implementation of VersionNumber. :)</div>
<div><br>
</div>
<div>- You cannot compare 4.1 to 3.1 because such branches are treated unordered.</div>
<div>- You cannot even compare 4.1.1 to 4.2.1 for the same reason. But you can compare 4.1 to 4.2 though.</div>
<div><br>
</div>
<div>This logic might be the reason to throw out the zero all together: 4.1 and 4.1.0 are not so different, yet the first will be comparable but the second will not. That "branch logic" seems to be the key. Try changing #initializeNumbers: to accept zero and
then play around with the comparison logic.</div>
<div><br>
</div>
<div>It's kind of weird or at least incomprehensible. I cannot find useful comments either. </div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="m_5038442811765340140m_767816493456297640m_4569841657242251591m_2551634508952807801m_6604156934940700848mb_sig"></div>
<blockquote class="m_5038442811765340140m_767816493456297640m_4569841657242251591m_2551634508952807801m_6604156934940700848history_container" type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:#aaaaaa;margin-top:10px">Am 20.09.2017 20:34:36 schrieb Tobias Pape <<a href="mailto:das.linux@gmx.de" target="_blank">das.linux@gmx.de</a>>:</p>
Hi,<br>
<br>
what's the rationale of VersionNumber prohibiting zeros in any of the version parts?<br>
Eg, 4.0.3 is not a valid VersionNumber currently. <br>
<br>
Best regards<br>
-Tobias<br>
<br>
</blockquote>
</div>
</div>
</blockquote></div></div>
</div></div>
</div>
</blockquote>
</div></div></div></div><br><br>
<br></blockquote></div><br></div></div>
</blockquote></div></div></div><br><br>
<br></blockquote></div><br></div></div>