<body><div id="__MailbirdStyleContent" style="font-size: 12pt;font-family: calibri;color: #000000">
The "self userInterfaceTheme color" is the preferred one because it takes advantage of implicit classification for the respective properties. :)<div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 12.10.2017 18:07:53 schrieb H. Hirzel <hannes.hirzel@gmail.com>:</p>I agree not to mix the two different types of calls.<br><br>But my question is<br><br>what is to be preferred?<br><br>--Hannes<br><br>On 10/12/17, Marcel Taeumel <marcel.taeumel@hpi.de> wrote:<br>> To make it consistent with the other change in #borderColor.<br>><br>> If you want to use themes, change it back for all calls to the theme. I<br>> would rather not mix #get:for: and the normal theme use in the same class.<br>><br>> Best,<br>> Marcel<br>> Am 12.10.2017 17:59:11 schrieb H. Hirzel <hannes.hirzel@gmail.com>:<br>> Thank you Marcel for the user interface theme updates.<br>><br>> Could you please elaborate why you go for<br>><br>> + ^ (UserInterfaceTheme current get: #titleColor for:<br>> #MenuMorph) ifNil: [ Color transparent]!<br>><br>> instead of<br>><br>> - ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!<br>><br>> ?<br>><br>> --Hannes<br>><br>> On Thu, 12 Oct 2017 15:49:44 0000, commits@source.squeak.org<br>> wrote:<br>>> Marcel Taeumel uploaded a new version of EToys to project The Trunk:<br>>> http://source.squeak.org/trunk/EToys-mt.309.mcz<br>>><br>>> ==================== Summary ====================<br>>><br>>> Name: EToys-mt.309<br>>> Author: mt<br>>> Time: 12 October 2017, 5:48:05.311645 pm<br>>> UUID: 7304d54f-0e5e-2f43-86ba-e4e2bca32a8b<br>>> Ancestors: EToys-hjh.279, EToys-hjh.308<br>>><br>>> For consistency regarding EToys-hjh.279<br>>><br>>> =============== Diff against EToys-hjh.308 ===============<br>>><br>>> Item was changed:<br>>> ----- Method: StandardScriptingSystem>>baseColor (in category<br>>> '*Etoys-Squeakland-tile colors') -----<br>>> baseColor<br>>> + ^ (UserInterfaceTheme current get: #titleColor for: #MenuMorph) ifNil:<br>>> [<br>>> Color transparent]!<br>>> -<br>>> - ^ self userInterfaceTheme baseColor ifNil: [Color transparent]!<br>>><br>>> Item was changed:<br>>> ----- Method: StandardScriptingSystem>>borderColor (in category<br>>> '*Etoys-Squeakland-tile colors') -----<br>>> borderColor<br>>> + ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:<br>>> [(Color r: 0.2 g: 0.3 b: 0.9)]!<br>>> - ^ (UserInterfaceTheme current get: #borderColor for: #MenuMorph) ifNil:<br>>> [(Color r: 0.2 g: 0.3 b: 0.9)]!<br>>><br>>><br>>><br>><br>><br><br></hannes.hirzel@gmail.com></marcel.taeumel@hpi.de>
</blockquote>
</div></body>