<body><div id="__MailbirdStyleContent" style="font-size: 12pt;font-family: calibri;color: #000000">
Hi Dave,<div><br></div><div>#finalExitActions: should not contain such critical code. That's what I meant. :) I see it more like a "Template Method" that does nothing serious by default.</div><div><br></div><div>Maybe we could reset <span style="font-family: tahoma, verdana;font-size: 13px;line-height: 19.5px">EmergencyRecoveryRequested in #enter:revert:saveForRevert: so that #finalExitActions: becomes free again. :-)</span></div><div><span style="font-family: tahoma, verdana;font-size: 13px;line-height: 19.5px"><br></span></div><div><span style="font-family: tahoma, verdana;font-size: 13px;line-height: 19.5px">Best,</span></div><div><span style="font-family: tahoma, verdana;font-size: 13px;line-height: 19.5px">Marcel</span></div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 14.12.2017 14:49:21 schrieb David T. Lewis <lewis@mail.msen.com>:</p>Hi Marcel,<br><br>On Thu, Dec 14, 2017 at 10:18:33AM +0100, Marcel Taeumel wrote:<br>> Hi Davis,<br>> <br>> I finally looked at your changes. :) So far, they are reasonable. However, the mere wish for not just entering parent projects for recovery but any other introduces a complexity that I am not really happy with. The class var EmergencyRecoveryRequested requires you to:<br>> <br>> - take care of the code for set/clear??EmergencyRecoveryRequested??across multiple methods<br><br>Did I make a mistake (again!?!) in these updates? There should be only two<br>references to EmergencyRecoveryRequested in the image. These are:<br><br> Project>>enterForEmergencyRecovery<br> Project>>finalExitActions:<br><br><br>> - makes the super call in #finalExitActions: mandatory, which is dangerous in my opinion and easy to miss in new kinds of projects<br>> <br>> The whole reason for this change is that we think that programmers are not able to establish a safety net of different parent projects on their own. Yet, we should rather pre-configure parent projects for the next release so that nobody has to worry. Maybe the SqueakShell at its root project.<br>> <br>> So, overall, this is a -1 from me here. Sorry.??<br><br><br>OK, thanks for reviewing :-)<br><br>It was an interesting exercise to figure out how to make this work. I may<br>play with the idea some more in my own image.<br><br>> <br>> Here is another take on #tryOtherProjectForRecovery: ??What about creating a new project of a different kind? Or re-ordering existing projects as parents? Nevertheless, I think that we should just pre-configure parent projects.<br><br>This hard part is to find something that does not add additional complexity<br>to the emergency mechanism. I would be nervous about trying to create a new<br>project or reoorder the existing hierarchy, but if someone can find a way to<br>do it, that would be good.<br><br>I do like the idea of having a SqueakShell as the root project, so that might<br>be a good thing to try. For myself, I am more comfortable dropping into MVC in<br>case of an error, but that may be only because I am already familiar with the<br>debugger in MVC. In the general case, dropping into a SqueakShell might be<br>better, I'm not sure.<br><br>Thanks,<br>Dave<br><br>> <br>> Best,<br>> Marcel<br>> <br>> Am 13.12.2017 22:28:05 schrieb David T. Lewis <lewis@mail.msen.com>:<br>> On Tue, Dec 12, 2017 at 10:42:54PM -0500, David T. Lewis wrote:<br>> > On Mon, Dec 11, 2017 at 08:38:51AM -0500, David T. Lewis wrote:<br>> > > I think that it wlll work with the most recent versions of Morphic-dtl.1376,<br>> > > ST80-dtl.233, and System-dtl.983 in the inbox.<br>> > ><br>> > > I'll check it later tonight to make sure.<br>> ><br>> > Unfortunately I am not able to test the sound service, because I do not<br>> > have sound output on the cog/spur VMs on my Linux computer. Maybe someone<br>> > else can double check to make sure that #letTheMusicPlay still works. I<br>> > think I have it right, but I can't verify it on my PC.<br>> ><br>> > I am attaching a change set with the lastest version of the changes, which<br>> > may be more convenient that loading the MCZs from the inbox.<br>> ><br>> > Dave<br>> ><br>> <br>> If no objections, I will merge this into trunk in another day or so.<br>> <br>> Dave<br>> <br>> <br><br>> <br><br><br></lewis@mail.msen.com>
</blockquote>
</div></body>