<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 5, 2018 at 8:39 PM, Eliot Miranda <span dir="ltr"><<a href="mailto:eliot.miranda@gmail.com" target="_blank">eliot.miranda@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Marcel, Hi David,<div><br></div><div>    hmm, I went ahead and made the split anyway but I think I've just complicated things unnecessarily.  I'm still having to wait for the very slow "Checking for undeclared symbols" pass to complete before being asked.  So I may revert (and feel free to revert if you don't like the code).</div></div></blockquote><div><br></div><div>Ugh, I nuked the version.  Preferences don't get set until after the recompileAll step.  Doh!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Jan 5, 2018 at 8:21 PM,  <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eliot Miranda uploaded a new version of Compiler to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Compiler-eem.365.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/trunk<wbr>/Compiler-eem.365.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Compiler-eem.365<br>
Author: eem<br>
Time: 5 January 2018, 8:21:15.192014 pm<br>
UUID: e3702a86-124d-46ca-bd7d-0707ab<wbr>249ab4<br>
Ancestors: Compiler-eem.364<br>
<br>
Make reindexingLiteralsDo: more robust when literals get added during blocks and hence weren't saved before the block was generated.<br>
<br>
=============== Diff against Compiler-eem.364 ===============<br>
<br>
Item was changed:<br>
  ----- Method: BytecodeEncoder>>reindexingLit<wbr>eralsDo: (in category 'code generation') -----<br>
  reindexingLiteralsDo: aBlock<br>
        | savedLiterals saveBlock |<br>
        savedLiterals := PluggableDictionary new equalBlock: litSet equalBlock.<br>
        saveBlock := [:assoc| savedLiterals at: assoc key put: assoc value shallowCopy].<br>
        litSet associationsDo: saveBlock.<br>
        litIndSet associationsDo: saveBlock.<br>
        selectorSet associationsDo: saveBlock.<br>
        ^aBlock ensure:<br>
                [| restoreBlock |<br>
+                restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key ifAbsent: [assoc value])].<br>
-                restoreBlock := [:assoc| assoc value resetFromCopy: (savedLiterals at: assoc key)].<br>
                 litSet associationsDo: restoreBlock.<br>
                 litIndSet associationsDo: restoreBlock.<br>
                 selectorSet associationsDo: restoreBlock]!<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-1653222250117329410gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>