<body><div id="__MailbirdStyleContent" style="font-size: 12pt;font-family: calibri;color: #000000">
HI Eliot,<div><br></div><div>what about a method like "ReleaseBuilder >> #releaseLocally"? Then put both into a category like "testing"? Would be easier to change than a class-inst-var.</div><div><br></div><div>Best,</div><div>Marcel</div><div class="mb_sig"></div><blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 06.01.2018 05:09:15 schrieb Eliot Miranda <eliot.miranda@gmail.com>:</p>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr">Hi Marcel, Hi David,<div><br></div><div> in modifying the ReleaseBuilder to allow the SistaV1 bytecode set to be selected I'm not happy having to wait until all the checking before prompting to use the bytecode set. One could move the query earlier, into setPreferences, but this means that the bytecode set would be in use before the Compiler recompileAll step, and that isn't desirable while debugging the byte code set. Would you object to me adding an instance variable to ReleaseBuilder class, useNewBytecodeSet or some such, which would be set in setPreferences and read in recompileAll?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 5, 2018 at 7:20 PM, <span dir="ltr"><<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Eliot Miranda uploaded a new version of ReleaseBuilder to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/ReleaseBuilder-eem.172.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/<wbr>trunk/ReleaseBuilder-eem.172.<wbr>mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: ReleaseBuilder-eem.172<br>
Author: eem<br>
Time: 5 January 2018, 7:20:47.150059 pm<br>
UUID: 4144895f-5617-4f80-9ab2-<wbr>593eca77e2ac<br>
Ancestors: ReleaseBuilder-mt.171<br>
<br>
Allow the ReleaseBuilder to query if the SistaV1 bytecode set should be the default in a new release.<br>
<br>
=============== Diff against ReleaseBuilder-mt.171 ===============<br>
<br>
Item was changed:<br>
----- Method: ReleaseBuilder class>>prepareSourceCode (in category 'preparing') -----<br>
prepareSourceCode<br>
"Update code. Remove foreign packages."<br>
<br>
MCMcmUpdater defaultUpdateURL: self buildRepository description.<br>
<br>
MCMcmUpdater updateMissingPackages: true.<br>
MCMcmUpdater enableUpdatesForAllPackages.<br>
<br>
TestCase new ensureInternetConnectionTo: self buildRepository description.<br>
<br>
"Flush all caches. If a previous download failed this is often helpful"<br>
MCFileBasedRepository flushAllCaches.<br>
<br>
"Save the current default updater, clear the registry, and re-register the current updater"<br>
MCMcmUpdater clearRegistry.<br>
<br>
[MCMcmUpdater default doUpdate: false. "non-interactive"]<br>
on: MCEmptyVersion do: [:warning | warning resume].<br>
<br>
self<br>
unloadForeignPackages;<br>
checkForDirtyPackages;<br>
loadWellKnownPackages;<br>
+ checkForUndeclaredSymbols;<br>
+ recompileAll!<br>
- checkForUndeclaredSymbols.<br>
-<br>
- Compiler recompileAll.!<br>
<br>
Item was added:<br>
+ ----- Method: ReleaseBuilder class>>recompileAll (in category 'scripts - support') -----<br>
+ recompileAll<br>
+<br>
+ (Smalltalk classNamed: #EncoderForSistaV1) ifNotNil:<br>
+ [:sistaBytecodeSet|<br>
+ CompiledCode preferredBytecodeSetEncoderCla<wbr>ss ~~ sistaBytecodeSet ifTrue:<br>
+ [(Project uiManager<br>
+ confirm: 'Do you want to make it the default in this release?'<br>
+ orCancel: [false]<br>
+ title: 'The SistaV1 Bytecode Set Is Available') ifTrue:<br>
+ [CompiledCode<br>
+ installSecondaryBytecodeSet: sistaBytecodeSet;<br>
+ preferredBytecodeSetEncoderCla<wbr>ss: sistaBytecodeSet]]].<br>
+<br>
+ Compiler recompileAll!<br>
<br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size: 10pt;border-collapse: separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div>
</blockquote>
</div></body>