<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><font face="Georgia">looks like it was known at the time</font></p>
<p><font face="Georgia"><br>
</font></p>
<table style="font-family: Times; letter-spacing: normal; orphans:
2; text-indent: 0px; text-transform: none; widows: 2;
word-spacing: 0px; -webkit-text-stroke-width: 0px;
text-decoration-style: initial; text-decoration-color: initial;
border: 1px solid rgb(0, 0, 255);" cellspacing="0" cellpadding="0"
width="100%" border="0">
<tbody>
<tr>
<td style="background-color: rgb(222, 222, 255);
border-bottom: 1px solid rgb(0, 0, 255);" valign="middle"
align="center"><a href="http://www.squeak.org/"><img
src="http://lists.squeakfoundation.org/pipermail/squeak-dev/images/sf_topleft.gif"
border="0"></a></td>
<td style="background-color: rgb(222, 222, 255);
border-bottom: 1px solid rgb(0, 0, 255);"><br>
</td>
</tr>
<tr>
<td colspan="2" valign="top">
<table cellpadding="10" border="0">
<tbody>
<tr>
<td valign="top">
<h2 style="background-color: rgb(222, 222, 255);">[squeak-dev]
Re: raised & inset borders</h2>
<b>Levente Uzonyi</b><span> </span><a
href="mailto:squeak-dev%40lists.squeakfoundation.org?Subject=%5Bsqueak-dev%5D%20Re%3A%20raised%20%26%20inset%20borders&In-Reply-To=1643e85c-a2ab-9f9b-3c1b-e19c05f171f1%40heeg.de"
title="[squeak-dev] Re: raised & inset
borders">leves at caesar.elte.hu<span> </span></a><br>
<i>Thu Nov 3 22:22:26 UTC 2016</i>
<ul>
<li>Previous message:<span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/192307.html">[squeak-dev]
raised & inset borders</a></li>
<li>Next message:<span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/192318.html">[squeak-dev]
Re: raised & inset borders</a></li>
<li><b>Messages sorted by:</b><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/date.html#192317">[
date ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/thread.html#192317">[
thread ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/subject.html#192317">[
subject ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/author.html#192317">[
author ]</a></li>
</ul>
<hr>
<pre>Hi Hans-Martin,
My intention was to always initialize baseColor, because nil was used as a
substitute of Color transparent back and forth for seemingly no reason.
I must have overlooked those #trackColorFrom: methods, and I think
replacing ifNil: with isTransparent ifTrue: in them is the right fix.
If you have a better solution in mind, let me know. Or I'll push the above
fix this week to the Trunk.
Levente
On Tue, 1 Nov 2016, Hans-Martin Mosner wrote:
><i> Looks like there is a regression with raised and inset borders. The method #initialize in SimpleBorder sets baseColor to
</i>><i> "Color transparent", which prevents #trackColorFrom: in its subclasses to work correctly.
</i>><i>
</i>><i> Since it is unclear to me whether it would have unintended side effects if the initialization of baseColor was removed,
</i>><i> I've added a check for transparent baseColor in all three trackColorFrom: methods, but that looks a bit ugly.
</i>><i>
</i>><i> Levente, the method is from April 2016 and carries your initials - do you remember what the motivation for this change was?
</i>><i>
</i>><i>
</i>><i> Cheers,
</i>><i>
</i>><i> Hans-Martin
</i>><i>
</i>><i>
</i>><i>
</i></pre>
<hr>
<ul>
<li>Previous message:<span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/192307.html">[squeak-dev]
raised & inset borders</a></li>
<li>Next message:<span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/192318.html">[squeak-dev]
Re: raised & inset borders</a></li>
<li><b>Messages sorted by:</b><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/date.html#192317">[
date ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/thread.html#192317">[
thread ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/subject.html#192317">[
subject ]</a><span> </span><a
href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2016-November/author.html#192317">[
author ]</a></li>
</ul>
<hr><a
href="http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/squeak-dev">More
information about the Squeak-dev mailing list</a></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
<br>
<br>
<div class="moz-cite-prefix">On 4/23/18 3:50 AM, Marcel Taeumel
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:452ac0ec-46e8-4e6f-afd1-808a042c7daf@getmailbird.com">
<div id="__MailbirdStyleContent" style="font-size:
12pt;font-family: calibri;color: #000000"> Oh, hmmm... Well,
what was the intention behind the change? I can see the stamp:
<div><br>
</div>
<div>ul 11/2/2016 09:46</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<blockquote class="history_container" type="cite"
style="border-left-style:solid;border-width:1px;
margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 20.04.2018
15:05:24 schrieb Bob Arning <a class="moz-txt-link-rfc2396E" href="mailto:arning315@comcast.net"><arning315@comcast.net></a>:</p>
<p><span style="font-family: Georgia">it used to be that
baseColor would be nil and<br>
</span></p>
<p><span style="font-family: Georgia">RaisedBorder>>trackColorFrom:
aMorph<br>
baseColor ifNil:[self color: aMorph raisedColor].</span><br>
</p>
would set the appropriate color, but now baseColor is set to
Color transparent in the #initialize method and setting the
raised color never happens.<br>
<br>
<div class="moz-cite-prefix">On 4/20/18 8:25 AM, David T.
Lewis wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180420122513.GA73749@shell.msen.com">
<pre wrap="">Thanks, I see it now.
The problem is also present in my "V3 trunk image", exactly as in the
trunk image. So it is not related to any differences in the coversion
to Spur in Squeak 5. It must be some other problem that was introduced
between Squeak 4.5 and 5.1.
I checked Squeak5.0-15113, and the problem is not happening there.
So ... it looks like something that was introduced between 5.0 and 5.1.
Dave
On Fri, Apr 20, 2018 at 06:59:49AM +0200, karl ramberg wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
This should show a thick border on the morph, with a simple raised
"ilusion".
Should be same border width as second rectangle with a red border.
RectangleMorph new borderColor: #raised; borderWidth: 10; openInWorld
RectangleMorph new borderColor: Color red; borderWidth: 10; openInWorld
Best,
Karl
On Fri, Apr 20, 2018 at 2:57 AM, David T. Lewis <a class="moz-txt-link-rfc2396E" href="mailto:lewis@mail.msen.com" moz-do-not-send="true"><lewis@mail.msen.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Karl,
Can you explain how I can see the problem with #raised and #inset borders?
I have a trunk level V3 image for comparison, so I can check if it might be
something related to the image conversion.
Dave
On Thu, Apr 19, 2018 at 10:04:32PM +0200, karl ramberg wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hm,
Actually broken in 5.0
Image conversion issue ??
Best,
Karl
On Thu, Apr 19, 2018 at 9:56 PM, karl ramberg <a class="moz-txt-link-rfc2396E" href="mailto:karlramberg@gmail.com" moz-do-not-send="true"><karlramberg@gmail.com></a>
</pre>
</blockquote>
<pre wrap="">wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Well,
These border styles have been broken for some time.
I checked some old images and it worked in the 4.6 image but not in
</pre>
</blockquote>
</blockquote>
<pre wrap="">5.1 so
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">something changed between there :-)
Best,
Karl
On Thu, Apr 19, 2018 at 11:44 AM, Marcel Taeumel <
</pre>
</blockquote>
</blockquote>
<pre wrap=""><a class="moz-txt-link-abbreviated" href="mailto:marcel.taeumel@hpi.de" moz-do-not-send="true">marcel.taeumel@hpi.de</a>>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Well, they kind of work if you set the #baseColor in the respective
border style. Otherwise, yes, I noticed that, too. At least the Mines
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">game
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">draws the fields on its own. So, there might be a bug hidden in
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">drawing
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">those border styles.
Best,
Marcel
Am 18.04.2018 20:31:31 schrieb karl ramberg <a class="moz-txt-link-rfc2396E" href="mailto:karlramberg@gmail.com" moz-do-not-send="true"><karlramberg@gmail.com></a>:
Hi,
#inset and #raised does not work either with or without Marcels
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">changeset.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Best,
Karl
On Tue, Apr 17, 2018 at 6:50 PM, karl ramberg <a class="moz-txt-link-rfc2396E" href="mailto:karlramberg@gmail.com" moz-do-not-send="true"><karlramberg@gmail.com></a>
wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
Slightly off topic:
I have been looking at border stuff in latest Trunk image and I can't
get border #inset and #raised to work.
The complex borders work.
Best,
Karl
On Sun, Apr 15, 2018 at 9:34 AM, Marcel Taeumel <
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap=""><a class="moz-txt-link-abbreviated" href="mailto:marcel.taeumel@hpi.de" moz-do-not-send="true">marcel.taeumel@hpi.de</a>>
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Thanks Karl and Dave. Chris, does it work in your image(s)?
Best,
Marcel
Am 14.04.2018 21:00:55 schrieb David T. Lewis <<a class="moz-txt-link-abbreviated" href="mailto:lewis@mail.msen.com" moz-do-not-send="true">lewis@mail.msen.com</a>
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">On Thu, Apr 12, 2018 at 11:23:42PM -0700, marcel.taeumel wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Anybody? Just file it in your work image and tell me what happens.
</pre>
</blockquote>
<pre wrap="">Sorry I overlook this. I filed the changes in earlier today. All is
well with browsers and such, but when I open an Elipse from the
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">Objects
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">tab, then rotate it with the halo handle, things go wrong. It looks
like the 'closed' instance variable in the PolygonMorph is nil.
I think you may have already addressed this from Karl's report.
Dave
</pre>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
</blockquote>
<blockquote type="cite"> </blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</blockquote>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>