<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><span style="font-family:arial,sans-serif;color:rgb(34,34,34)">On 26 April 2018 at 11:28, marcel.taeumel </span><span dir="ltr" style="font-family:arial,sans-serif;color:rgb(34,34,34)"><<a href="mailto:Marcel.Taeumel@hpi.de" target="_blank">Marcel.Taeumel@hpi.de</a>></span><span style="font-family:arial,sans-serif;color:rgb(34,34,34)"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi, there.<br>
<br>
I cannot put a ByteString into a ByteArray via a WriteStream anymore:<br>
<br>
| s |<br>
s := WriteStream on: ByteArray new.<br>
s nextPutAll: 'hello'.<br>
<br>
You need to do:<br>
<br>
| s |<br>
s := WriteStream on: ByteArray new.<br>
s nextPutAll: 'hello' asByteArray.<br>
<br>
This breaks code.<br>
<br>
Best,<br>
Marcel<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">​Tech​nically this is an expected error - you simply cannot put Characters (the elements of a String) into a ByteArray. However, for convenience we do support copying Strings into ByteArrays in various places, including <span style="color:rgb(0,0,0);font-family:arial,helvetica,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">WriteStream>><wbr>nextPutAll:.</span></div></div><div><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)">However, the test in <span style="color:rgb(0,0,0);font-family:arial,helvetica,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">WriteStream>>nextPutAll: is too strict. It needs to be "collection class isBits" instead of "<span style="color:rgb(0,0,0);font-family:arial,helvetica,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">collection isString". This makes the code actually match its comment:</span></span></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small;color:rgb(0,0,0)"><br></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif">WriteStream>>nextPutAll: aCollection</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">   </span>| newEnd |</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">      </span>(collection class == aCollection class</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">          </span>or: [ collection <span style="color:rgb(0,0,0);font-family:arial,helvetica,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">class isBits</span></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">                        </span>and: [ aCollection isString</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">                     </span>and: [ collection class format = aCollection class format ] ] ]) "Let Strings with the same field size as collection take the quick route too."</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">               </span>ifFalse: [ ^ super nextPutAll: aCollection ].</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap"> </span>newEnd := position + aCollection size.</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">  </span>newEnd > writeLimit ifTrue:</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">          </span>[self growTo: newEnd + 10].</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">   </span>collection replaceFrom: position+1 to: newEnd  with: aCollection startingAt: 1.</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">        </span>position := newEnd.</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><span style="white-space:pre-wrap">     </span>^aCollection​</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif">With that change your example works. I think this was the original intent of the code.</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif">Fixed in Collections-bf.787</font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font color="#000000" face="arial, helvetica, sans-serif">- Bert - </font></div><div class="gmail_default"><br></div></div></div></div>