<div dir="ltr">Hi Chris,<div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 9, 2018 at 10:49 AM, Chris Muller <span dir="ltr"><<a href="mailto:asqueaker@gmail.com" target="_blank">asqueaker@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It appears I forgot to delete the mailout bug report method, too...<br>
but is it okay to remove or should it be deprecated? Only one sender,<br>
so I think remove, but Marcel may prefer deprecation. Marcel?<br></blockquote><div><br></div><div>My inclination would be to keep it as a nice example of sending email in Squeak, and I would address Tim' criticism by making sure that setting up email preferences was easy. Being able to send email isn't widely used but it is very useful in some circumstances. Either email is in an well supported or out in its own package. Arguably, what we have is sitting on the fence.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I can take care of that isKindOf: while I'm there...<br></blockquote><div><br></div><div>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
On Wed, May 9, 2018 at 12:45 PM, Chris Muller <<a href="mailto:asqueaker@gmail.com">asqueaker@gmail.com</a>> wrote:<br>
> Hi Eliot,<br>
><br>
>> two things. First this is an opportunity to replace (class isKindOf:<br>
>> Behavior) with class isBehavior.<br>
><br>
> Indeed, I wish I'd noticed that while I was in there. I'll see if any<br>
> other review comments pop up, before committing a new version.<br>
><br>
>> Second, why delete mail out bug report?<br>
>> It's still useful right?<br>
><br>
> Not really, either menu option puts the user within just a couple of<br>
> gestures of sending an email, so having both is fairly redundant.<br>
> This is a good opportunity to reduce the dependency coupling between<br>
> the debugger and emailing functionality, and possibly slightly improve<br>
> safety from accidentally sending sensitive information in an email<br>
> (since cutting and pasting contents of an email requires a more<br>
> separate, deliberate action, than "send a bug report", which sounds<br>
> totally innocent, but possibly encourage the user to not need to<br>
> scrutinize it for sensitive data). That may seem like over-thinking<br>
> it, but the one day it happens could lead to "headlines," :) so I<br>
> almost feel a warning to that effect before the stack trace would be a<br>
> good reminder...<br>
><br>
><br>
>> On Tue, May 8, 2018 at 8:59 PM, <<a href="mailto:commits@source.squeak.org">commits@source.squeak.org</a>> wrote:<br>
>>><br>
>>> Chris Muller uploaded a new version of Tools to project The Trunk:<br>
>>> <a href="http://source.squeak.org/trunk/Tools-cmm.812.mcz" rel="noreferrer" target="_blank">http://source.squeak.org/<wbr>trunk/Tools-cmm.812.mcz</a><br>
>>><br>
>>> ==================== Summary ====================<br>
>>><br>
>>> Name: Tools-cmm.812<br>
>>> Author: cmm<br>
>>> Time: 8 May 2018, 10:59:15.586524 pm<br>
>>> UUID: d05b5ccd-cc99-4f00-85b1-<wbr>264218092ef2<br>
>>> Ancestors: Tools-dtl.811<br>
>>><br>
>>> - Integrate newly-defined classes into the hierarchy list of a<br>
>>> HierarchyBrowser without muting the other classes. If it's outside the<br>
>>> hierarchy, spawn it in a new window.<br>
>>> - Bug reports can contain sensitive and/or private information (variable<br>
>>> values), so use care when sending them electronically. 'copy bug report to<br>
>>> clipboard' replaced 'mail out bug report' on the debugger menu.<br>
>>><br>
>>> =============== Diff against Tools-dtl.811 ===============<br>
>>><br>
>>> Item was changed:<br>
>>> ----- Method: Browser>>defineClass:<wbr>notifying: (in category 'class<br>
>>> functions') -----<br>
>>> defineClass: defString notifying: aController<br>
>>> "The receiver's textual content is a request to define a new<br>
>>> class. The<br>
>>> source code is defString. If any errors occur in compilation,<br>
>>> notify<br>
>>> aController."<br>
>>> | oldClass class newClassName defTokens keywdIx envt |<br>
>>> oldClass := self selectedClassOrMetaClass.<br>
>>> defTokens := defString findTokens: Character separators.<br>
>>><br>
>>> ((defTokens first = 'Trait' and: [defTokens second = 'named:'])<br>
>>> or: [defTokens second = 'classTrait'])<br>
>>> ifTrue: [^self defineTrait: defString notifying:<br>
>>> aController].<br>
>>><br>
>>> keywdIx := defTokens findFirst: [:x | x beginsWith: 'category'].<br>
>>> envt := self selectedEnvironment.<br>
>>> keywdIx := defTokens findFirst: [:x | '*subclass*' match: x].<br>
>>> newClassName := (defTokens at: keywdIx+1) copyWithoutAll: '#()'.<br>
>>> ((oldClass isNil or: [oldClass theNonMetaClass name asString ~=<br>
>>> newClassName])<br>
>>> and: [envt includesKey: newClassName asSymbol]) ifTrue:<br>
>>> ["Attempting to define new class over existing one<br>
>>> when<br>
>>> not looking at the original one in this<br>
>>> browser..."<br>
>>> (self confirm: ((newClassName , ' is an existing<br>
>>> class in this system.<br>
>>> Redefining it might cause serious problems.<br>
>>> Is this really what you want to do?') asText makeBoldFrom: 1 to:<br>
>>> newClassName size))<br>
>>> ifFalse: [^ false]].<br>
>>> "ar 8/29/1999: Use oldClass superclass for defining oldClass<br>
>>> since oldClass superclass knows the definerClass of oldClass."<br>
>>> oldClass ifNotNil:[oldClass := oldClass superclass].<br>
>>> class := envt beCurrentDuring:<br>
>>> [oldClass subclassDefinerClass<br>
>>> evaluate: defString<br>
>>> in: envt<br>
>>> notifying: aController<br>
>>> logged: false].<br>
>>> (class isKindOf: Behavior)<br>
>>> + ifTrue: [self changed: #systemCategoryList; changed:<br>
>>> #classList.<br>
>>> + self clearUserEditFlag; spawnOrNavigateTo:<br>
>>> class.<br>
>>> - ifTrue: [self changed: #systemCategoryList.<br>
>>> - self changed: #classList.<br>
>>> - self clearUserEditFlag.<br>
>>> - self setClass: class selector: nil.<br>
>>> - "self clearUserEditFlag; editClass."<br>
>>> ^ true]<br>
>>> ifFalse: [^ false]!<br>
>>><br>
>>> Item was added:<br>
>>> + ----- Method: Browser>>spawnOrNavigateTo: (in category 'private') -----<br>
>>> + spawnOrNavigateTo: aClass<br>
>>> + self setClass: aClass selector: nil!<br>
>>><br>
>>> Item was changed:<br>
>>> ----- Method: Debugger>><wbr>mainContextStackMenu: (in category 'context<br>
>>> stack menu') -----<br>
>>> mainContextStackMenu: aMenu<br>
>>> "Set up the menu appropriately for the context-stack-list,<br>
>>> unshifted"<br>
>>> <contextStackMenuShifted: false><br>
>>> ^ aMenu addList: #(<br>
>>> ('fullStack (f)'<br>
>>> fullStack)<br>
>>> ('restart (r)' restart)<br>
>>> ('proceed (p)' proceed)<br>
>>> ('step (t)'<br>
>>> doStep)<br>
>>> ('step through (T)'<br>
>>> stepIntoBlock)<br>
>>> ('send (e)'<br>
>>> send)<br>
>>> ('where (w)' where)<br>
>>> ('peel to first like this'<br>
>>> peelToFirst)<br>
>>> -<br>
>>> ('return entered value'<br>
>>> returnValue)<br>
>>> -<br>
>>> ('toggle break on entry'<br>
>>> toggleBreakOnEntry)<br>
>>> ('senders of (n)'<br>
>>> browseSendersOfMessages)<br>
>>> ('implementors of (m)' browseMessages)<br>
>>> ('inheritance (i)'<br>
>>> methodHierarchy)<br>
>>> -<br>
>>> ('versions (v)'<br>
>>> browseVersions)<br>
>>> -<br>
>>> ('references (r)'<br>
>>> browseVariableReferences)<br>
>>> ('assignments (a)'<br>
>>> browseVariableAssignments)<br>
>>> -<br>
>>> ('class refs (N)'<br>
>>> browseClassRefs)<br>
>>> ('browse full (b)'<br>
>>> browseMethodFull)<br>
>>> ('file out '<br>
>>> fileOutMessage)<br>
>>> -<br>
>>> + ('copy bug report to clipboard'<br>
>>> copyBugReportToClipboard));<br>
>>> - ('mail out bug report' mailOutBugReport)<br>
>>> - ('bug report to clipboard'<br>
>>> copyBugReportToClipboard));<br>
>>> yourself<br>
>>> !<br>
>>><br>
>>> Item was changed:<br>
>>> ----- Method: HierarchyBrowser>>setClass: (in category 'initialization')<br>
>>> -----<br>
>>> + setClass: aClass<br>
>>> + self initHierarchyForClass: (centralClass ifNil: [ aClass ]).<br>
>>> + super setClass: aClass!<br>
>>> - setClass: aClass<br>
>>> -<br>
>>> - self initHierarchyForClass: aClass.<br>
>>> - super setClass: aClass.!<br>
>>><br>
>>> Item was added:<br>
>>> + ----- Method: HierarchyBrowser>><wbr>spawnOrNavigateTo: (in category<br>
>>> 'private') -----<br>
>>> + spawnOrNavigateTo: aClass<br>
>>> + (aClass inheritsFrom: centralClass)<br>
>>> + ifTrue: [ super spawnOrNavigateTo: aClass ]<br>
>>> + ifFalse: [ self systemNavigation browseHierarchy: aClass<br>
>>> ]!<br>
>>><br>
>>> Item was changed:<br>
>>> ----- Method: HierarchyBrowser>><wbr>updateAfterClassChange (in category<br>
>>> 'initialization') -----<br>
>>> updateAfterClassChange<br>
>>> "It is possible that some the classes comprising the hierarchy<br>
>>> have changed, so reinitialize the entire browser."<br>
>>><br>
>>> + | priorSelection |<br>
>>> + priorSelection := self selectedClassName.<br>
>>> +<br>
>>> (centralClass notNil and: [centralClass isObsolete not])<br>
>>> + ifTrue: [self initHierarchyForClass: centralClass].<br>
>>> +<br>
>>> + (self classListIndexOf: priorSelection) > 0<br>
>>> + ifTrue: [self selectClassNamed: priorSelection].!<br>
>>> - ifTrue: [self initHierarchyForClass: centralClass]!<br>
>>><br>
>>><br>
>><br>
>><br>
>><br>
>> --<br>
>> _,,,^..^,,,_<br>
>> best, Eliot<br>
>><br>
>><br>
>><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><span style="font-size:small;border-collapse:separate"><div>_,,,^..^,,,_<br></div><div>best, Eliot</div></span></div></div></div>
</div></div>