<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><font face="Georgia">A useful step would be to check this:<br>
</font></p>
<p><font face="Georgia">(Text allInstances select: [ :e | e size ~=
e runs size]) explore<br>
</font></p>
<p><font face="Georgia">and see if it finds anything. If people did
it periodically (like before and after loading new code from
somewhere) we might know if/how these anomalies might be
created.</font><br>
</p>
<br>
<div class="moz-cite-prefix">On 7/5/18 12:14 PM, Tim Johnson wrote:<br>
</div>
<blockquote type="cite"
cite="mid:18217000-9D95-4C1B-AD00-23C100AA21E7@sonic.net">Hi all,
<div><br>
</div>
<div>I'm sorry if it seems like I may have wasted a dozen hours of
your time on a simple problem of a hand-edited changeset.</div>
<div><br>
</div>
<div>However, I honorably swear that (a) this problem was
happening to me before FooClient.cs even existed, and (b) this
has happened to me in various images maybe 3-6 times over the
past few years. And I'm not too exotic with my images: I just
use Monticello and fileIn/fileOut.</div>
<div><br>
</div>
<div>I notice (off-hand) that Monticello actually strips
formatting from class comments either during export or import,
and changesets do not.</div>
<div><br>
</div>
<div>I would like to be able to provide instructions for getting a
class into the problem condition, but I haven't found them yet.
I can provide my original class as a changeset without
modification, but not for a few days, as I am away from that
computer. </div>
<div><br>
</div>
<div>I am trying to reproduce the situation without the need to
share a changeset. This may involve finding the exact source of
the styled text which I pasted into the class comment. (I am
trying this in stock 5.1 image, in case improvements to the
boilerplate text could have something to do with this.)</div>
<div><br>
</div>
<div>My efforts to construct a test case are being hampered,
however. I'll post separately.</div>
<div><br>
</div>
<div>Thanks again,</div>
<div>Tim</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
<div>
<div>On Jul 5, 2018, at 4:17 AM, Bob Arning wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div text="#000000" bgcolor="#FFFFFF"> <font face="Georgia">Yes,
it is the cause and the editor could be a bit more
robust in the face of such puzzles. :-)<br>
<br>
</font>
<div class="moz-cite-prefix">On 7/5/18 2:01 AM, Tim
Johnson wrote:<br>
</div>
<blockquote type="cite"
cite="mid:B9B3118E-EA6A-4ABF-BDD7-F4CB12A9537E@sonic.net">Sorry:
I should have said my hand-renaming the class in the
.cs *may* be the cause of what you found, but not that
it necessarily *is* the cause of what you found.
<div><br>
</div>
<div>Thanks,</div>
<div>Tim<br>
<div><br>
<div>
<div>On Jul 4, 2018, at 10:59 PM, Tim Johnson
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space; ">Hi Bob & David,
<div><br>
</div>
<div>Thanks for all your help with this.</div>
<div><br>
</div>
<div>The runs are short because in my original
fileOut, the class was named MoodleClient,
but I hand-edited the .cs to rename it
FooClient and to remove all my proprietary
methods I'm not yet ready to share.</div>
<div><br>
</div>
<div>I did try to explain this in my original
post which is now in the distant realm of
the thread. :)</div>
<div><br>
</div>
<div>Best,</div>
<div>Tim</div>
<div><br>
<div>
<div>On Jul 4, 2018, at 3:55 PM, Bob
Arning wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta http-equiv="Content-Type"
content="text/html;
charset=windows-1252">
<div text="#000000" bgcolor="#FFFFFF">
<p><font face="Georgia">A little
more...</font></p>
<p><font face="Georgia">This problem
may ultimately be due to something
broken in the text being
displayed. If I look at the funky
class comment, it has these runs<br>
</font></p>
<p><font face="Georgia">a RunArray
runs: #(1 35 18 20 3) values: {#()
. {a TextFontChange font: 1} . #()
. {a TextEmphasis code: 1} . #()}</font></p>
<p><font face="Georgia">The total
length of the run sizes is 77, yet
the string is only 70 bytes long.</font></p>
<p><font face="Georgia">If I copy that
text out and paste into a
workspace, the runs now look like:<br>
</font></p>
<p><font face="Georgia">a RunArray
runs: #(1 35 18 16) values: {#() .
{a TextFontChange font: 1} . #() .
{a TextEmphasis code: 1}}</font></p>
<p><font face="Georgia">and the size
of the runs matches the size of
the string at 70. I wonder if
other occurrences of this problem
might have a similar cause.</font><br>
</p>
<br>
<div class="moz-cite-prefix">On 7/4/18
4:20 PM, David T. Lewis wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180704202031.GA65465@shell.msen.com">
<pre wrap="">On Wed, Jul 04, 2018 at 03:46:16PM -0400, Bob Arning wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Here is a side-by-side comparison with the styled version on the right
and the same text unstyled on the left. Note the difference in runStopIndex
</pre>
</blockquote>
<pre wrap="">I see it now. Thanks!
Dave
</pre>
<blockquote type="cite">
<pre wrap="">On 7/4/18 2:49 PM, David T. Lewis wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I tried reverting #scanCharactersFrom:to:in:rightX:stopConditions:kern:
to the earlier version (cmm 6/12/2010 11:52), but I still get failures
with cursor and mouse in the class comment text when browsing the FooClient
class. There must be something else going on here, and it is certainly
not obvious to me why it is happening only with the FooClient test
example.
Dave
On Wed, Jul 04, 2018 at 02:10:00PM -0400, Bob Arning wrote:
</pre>
<blockquote type="cite">
<pre wrap="">perhaps this will help:
This version does not seem to exhibit the error and it limits stopIndex
to the size of the string
!CharacterScanner methodsFor: 'scanning' stamp: 'cmm 6/12/2010 11:52'!
scanCharactersFrom: startIndex to: stopIndex in: sourceString rightX:
rightX stopConditions: stops kern: kernDelta
?????? | startEncoding selector |
?????? (sourceString isByteString) ifTrue: [^ self
basicScanCharactersFrom: startIndex *to: (stopIndex min: sourceString
size)* in: sourceString rightX: rightX stopConditions: stops kern:
kernDelta.].
?????? (sourceString isWideString) ifTrue: [
?????? ?????? startIndex > stopIndex ifTrue: [lastIndex := stopIndex. ^
stops endOfRun].
?????? ?????? startEncoding :=?? (sourceString at: startIndex)
leadingChar.
?????? ?????? selector := EncodedCharSet scanSelectorAt: startEncoding.
?????? ?????? ^ self perform: selector withArguments: (Array with:
startIndex with: stopIndex with: sourceString with: rightX with: stops
with: kernDelta).
?????? ].
?????? ^ stops endOfRun
! !
This version fails and does not limit the stopIndex.
!CharacterScanner methodsFor: 'scanning' stamp: 'nice 10/22/2013 20:49'!
scanCharactersFrom: startIndex to: stopIndex in: sourceString rightX:
rightX
?????? ^sourceString scanCharactersFrom: startIndex *to: stopIndex* with:
self rightX: rightX font: font! !
On 7/4/18 11:53 AM, David T. Lewis wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, Jul 04, 2018 at 02:35:59PM +0200, karl ramberg wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, Jul 4, 2018 at 11:10 AM K K Subbu <a class="moz-txt-link-rfc2396E" href="mailto:kksubbu.ml@gmail.com" moz-do-not-send="true"><kksubbu.ml@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Tuesday 03 July 2018 04:40 AM, Tim Johnson wrote:
</pre>
<blockquote type="cite">
<pre wrap="">1. File-in the .cs as attached*.
2. In a system browser, click on the class, then click on the [?]
button
to view class comment.
3. Notice the styled text in the comment.
4. Click around the comment pane a bit.
5. Eventually, see "Error: subscript is out of bounds: 71" appear over
and over until you interrupt.
</pre>
</blockquote>
<pre wrap="">In step 4, it is sufficient to click once near the bottom of the pane
when the cursor changes from I-bar to arrow and then wait. This will
trigger the error, but the error window triggers itself recursively
around 50 times before stopping and displaying the windows.
I added an assert to catch it before recursion:
self assert: lastIndex < sourceString size.
The assert window itself throws up another error, but that is a topic
for another thread ;-).
Regards .. Subbu
</pre>
</blockquote>
<pre wrap="">Hi,
See class comment i NewParagraph for a hint of what happens.
A empty lineSpan 71 to: 70 is added to the end of the paragraph, when
you
double click below the text.
When the character scanner looks for characters outside of the string at
index 71 it cause a recursion.
Best,
Karl
</pre>
</blockquote>
<pre wrap="">Good tiip to look at the NewParagraph class comment, there is apparently
some left over messiness in here somewhere.
Another way to trigger the bug using the test case with FooClient is
to position the cursor in the comment pane and use keyboard right cursor
to move to the end of the comment. This causes the same bounds error but
takes a different path through the code leading to the error.
Looking through the stack in a debugger after triggering the error with
the mouse, here are a few notes (but no conclusions):
On mouseUp: we enter Editor>>selectWord then call
Editor>>selectWordLeftDelimiters:rightDelimiters:
which has this:
"Select the whole text when clicking before first or after last
character"
(here > string size or: [here < 2]) ifTrue: [^self selectFrom: 1 to:
string size].
where string is the 70 character String derived from the Text.
At this point we are trying to select from 1 to 70 (the whole string for
the entire text) in TextEditor>>selectFrom:to:
This calls Editor>>selectInvisiblyFrom:to: and here the stop index is
set past the size of the string:
selectInvisiblyFrom: start to: stop
"Select the designated characters, inclusive. Make no visual
changes."
self markIndex: start pointIndex: stop + 1
>From this point we are trying to go from index 1 to index 71 over a
string
of size 70, and eventually end up with the out of bounds exception.
A clue that this might be accumulation of kludges: Looking at senders of
selectInvisiblyFrom:to: (such as TextEditor>>addText:event:) shows a
number
of methods that subtract 1 from the stop index when before calling the
method
that adds 1 back to the stop index. This certainly does not have a good
smell.
It is not clear to me why selectInvisiblyFrom:to: would be adding one to
the
stop index, but I see that the method stamp is jmv 5/27/2011, which
suggests
to me that we should take a look at Cuis to figure out how this is
intended
to function. Cuis does not show any cases of senders of
selectInvisiblyFrom:to:
that subtract 1 from the stop index, and the Cuis implementation of
selectInvisiblyFrom:to: is that same as Squeak.
Dave
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<blockquote type="cite"> </blockquote>
</blockquote>
<br>
</div>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<br>
</blockquote>
</div>
<br>
</div>
</div>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</div>
<br>
</blockquote>
</div>
<br>
</div>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>