<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hi Richo,<div><br></div><div> Integrated and a new plugin has been generated. <span style="background-color: rgba(255, 255, 255, 0);">Thanks!!</span><br><br><div id="AppleMailSignature" dir="ltr"><span style="background-color: rgba(255, 255, 255, 0);">_,,,^..^,,,_ (phone)</span></div><div dir="ltr"><br>On Nov 29, 2018, at 5:25 PM, Ricardo Moran <<a href="mailto:richi.moran@gmail.com">richi.moran@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hi,<br></div><div><br></div><div>I think I found a bug with the named serial ports in windows.</div><div>I can open a named port without problem the first time but if I close it and try to open it again it fails until I restart the image. This doesn't happen with numeric ports. I could reproduce this bug in both Squeak5.2 and Pharo6.1 (both using windows 8.1). </div><div><br></div><div>I think the problem is that SerialPort>>#primClosePortByName: calls the "primitiveSerialPortCloseByName" but I couldn't find this primitive anywhere in the SerialPlugin source (<a href="https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c">https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/src/plugins/SerialPlugin/SerialPlugin.c</a>). So I'm guessing that the port is never properly closed. </div><div><br></div><div>I added the missing primitive (find attached) and recompiled the vm, and now it seems to work. So my question is: how can I contribute this small fix? Should I commit to the VM Maker Inbox repository? </div><div><br></div><div>Thanks,</div><div>Richo</div></div></div>
</div></blockquote><blockquote type="cite"><div dir="ltr"><<a href="http://SerialPlugin-primitiveSerialPortCloseByName.st">SerialPlugin-primitiveSerialPortCloseByName.st</a>></div></blockquote><blockquote type="cite"><div dir="ltr"><span></span><br></div></blockquote></div></body></html>