<div dir="ltr">No, <div>targetOwner can be either nil or some morph in this method.</div><div>It's not a problem to send 'show' to a morph that is already visible.</div><div><div><br></div></div><div><br></div><div>Best,</div><div>Karl</div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 8, 2018 at 12:54 PM K K Subbu <<a href="mailto:kksubbu.ml@gmail.com">kksubbu.ml@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">targetOwner is not set in the "targetMorph ifNil:" part of the branch <br>
but is used after this test. Will this be an issue?<br>
<br>
Regards .. Subbu<br>
<br>
On 06/12/18 11:06 PM, karl ramberg wrote:<br>
> The preference triggers the error because ProjectViewMorph has the <br>
> SystemWindow as a owner and then it gets hidden when the targetOwner is <br>
> hidden.<br>
> I have to look at the other users of this method to understand why the <br>
> owner should be hidden. Nothing obvious comes to mind.<br>
> <br>
> Best,<br>
> Karl<br>
> <br>
> <br>
> On Thu, Dec 6, 2018 at 6:25 AM K K Subbu <<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a> <br>
> <mailto:<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a>>> wrote:<br>
> <br>
> There is also a targetMorph show later on in the method that has to be<br>
> removed.<br>
> <br>
> I doubt whether the preference has anything to do with the bug.<br>
> <br>
> While loading from the server, the system window (or the thumbnail) is<br>
> hidden and a translucent morph is placed over its bounds. When the<br>
> loading is complete, the steps are reversed. I suppose this is to<br>
> indicate that the thumbnail could change when a new version is loaded.<br>
> <br>
> This is holiday season so feedback may be slow in coming. In any case,<br>
> you could post a fix to the Inbox to trigger discussions.<br>
> <br>
> Regards .. Subbu<br>
> <br>
> On 06/12/18 3:25 AM, karl ramberg wrote:<br>
> > The problem does not happen when ProjectViewInWindow preference<br>
> is false.<br>
> ><br>
> > In ComplexProgressIndicator>>withProgressDo:<br>
> > Comment out<br>
> > targetOwner ifNotNil: [targetOwner hide].<br>
> ><br>
> > I'm not sure why the owner of the ProjectViewMorph should ever<br>
> hide here.<br>
> > There could be some edge case I'm not aware of.<br>
> ><br>
> > If nobody see an issue with this I'll make a change and push to trunk<br>
> ><br>
> > Cheers,<br>
> > Karl<br>
> ><br>
> ><br>
> > On Wed, Dec 5, 2018 at 8:47 AM K K Subbu <<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a><br>
> <mailto:<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a>><br>
> > <mailto:<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a> <mailto:<a href="mailto:kksubbu.ml@gmail.com" target="_blank">kksubbu.ml@gmail.com</a>>>> wrote:<br>
> ><br>
> > On 28/11/18 1:28 AM, Tim Johnson wrote:<br>
> > ><br>
> > > I did World menu->open->morphic project. (I can enter it and<br>
> > return, or<br>
> > > not enter it at all, and it has no effect on what I'm<br>
> reporting<br>
> > here.)<br>
> > ><br>
> > > I then menu-clicked inside the project's thumbnail and<br>
> chose "see if<br>
> > > server version is more recent."<br>
> > ><br>
> > > This brings up a chooser dialog and makes the project<br>
> thumbnail<br>
> > morph<br>
> > > disappear.<br>
> ><br>
> > The project view morph is enclosed in a system window which<br>
> gets hidden<br>
> > while displaying a progress dialog to check on server. If the<br>
> dialog is<br>
> > dismissed, it continues to stay hidden :-(. I suspect this is<br>
> because<br>
> ><br>
> > ProjectViewMorph>>checkForNewerVersionAndLoad<br>
> > self withProgressDo: [<br>
> > project loadFromServer<br>
> > ]<br>
> ><br>
> > loadFromServer displays a progress bar when required, so I<br>
> wonder why<br>
> > withProgressDo: is required again. If I remove this check and<br>
> change to<br>
> ><br>
> > project loadFromServer<br>
> ><br>
> > then the problem gets solved. I don't know enough about<br>
> project loading<br>
> > to confirm if this is indeed the correct solution.<br>
> ><br>
> > Regards .. Subbu<br>
> ><br>
> ><br>
> ><br>
> <br>
> <br>
> <br>
> <br>
<br>
<br>
</blockquote></div>